Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Robustness improvements to datadog_diagnostics plugin #723

Merged
merged 1 commit into from
Jul 11, 2024

Commits on Jul 11, 2024

  1. feat: Robustness improvements to datadog_diagnostics plugin

    - Add `DATADOG_DIAGNOSTICS_ENABLE` for quick disable if needed
    - Limit spans with `DATADOG_DIAGNOSTICS_MAX_SPANS` (default 100)
    - Fix scope of member variables
    - Add unit tests
    
    Manual testing:
    
    - Modify `common.djangoapps.student.views.dashboard.student_dashboard` in
      edx-platform to call `import time; time.sleep(10)` at the start of the
      view.
    - Start server and log
    - Visit /dashboard
    - While the browser is waiting, quickly make a small edit to an
      edx-platform file, causing an autoreload.
    - Confirm that spans are logged.
    timmc-edx committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    63a2478 View commit details
    Browse the repository at this point in the history