ESQL: Fix test failure around field loading #111058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the time limit. Sometimes the test data is big enough to warrant more time. And CI isn't always fast. Closes elastic#111048 Closes elastic#110244
nik9000
added
>test
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
removed
needs:risk
craigtaverner
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
LGTM. This test class was based very much on ValuesSourceReaderOperatorTests, so I wonder if that is also close to the edge in terms of time. This test class is also possibly more complex than it really needs to be, but refining it will take time, as it was time consuming to write in the first place.
nik9000
removed
the
auto-backport-and-merge
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
Bumps the time limit. Sometimes the test data is big enough to warrant more time. And CI isn't always fast. Closes elastic#111048 Closes elastic#110244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the time limit. Sometimes the test data is big enough to warrant more time. And CI isn't always fast. Closes #111048
Closes #110244