Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Fix test failure around field loading #111058

Merged
merged 5 commits into from
Jul 22, 2024
Merged

ESQL: Fix test failure around field loading #111058

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a64b3cd
ESQL: Fix test failure around field loading
nik9000 Jul 18, 2024
3b94846
Merge branch 'main' into vs_reader_fail_fix
nik9000 Jul 18, 2024
d83e85a
Merge branch 'main' into vs_reader_fail_fix
nik9000 Jul 19, 2024
e277d8f
Drop merge error
nik9000 Jul 19, 2024
b97d511
Merge branch 'main' into vs_reader_fail_fix
nik9000 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ tests:
- class: org.elasticsearch.upgrades.SecurityIndexRolesMetadataMigrationIT
method: testMetadataMigratedAfterUpgrade
issue: https://github.com/elastic/elasticsearch/issues/110232
- class: org.elasticsearch.compute.lucene.ValueSourceReaderTypeConversionTests
method: testLoadAll
issue: https://github.com/elastic/elasticsearch/issues/110244
- class: org.elasticsearch.backwards.SearchWithMinCompatibleSearchNodeIT
method: testMinVersionAsNewVersion
issue: https://github.com/elastic/elasticsearch/issues/95384
Expand Down Expand Up @@ -97,9 +94,6 @@ tests:
- class: org.elasticsearch.ingest.geoip.EnterpriseGeoIpDownloaderIT
method: testEnterpriseDownloaderTask
issue: https://github.com/elastic/elasticsearch/issues/111002
- class: org.elasticsearch.compute.lucene.ValueSourceReaderTypeConversionTests
method: testLoadAllStatusAllInOnePage
issue: https://github.com/elastic/elasticsearch/issues/111048
- class: org.elasticsearch.action.search.KnnSearchSingleNodeTests
method: testKnnSearchAction
issue: https://github.com/elastic/elasticsearch/issues/111072
Expand Down
6 changes: 5 additions & 1 deletion .../src/test/java/org/elasticsearch/compute/lucene/ValueSourceReaderTypeConversionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1549,7 +1549,11 @@ protected void start(Driver driver, ActionListener<Void> driverListener) {
PlainActionFuture<Void> future = new PlainActionFuture<>();
try {
driverRunner.runToCompletion(drivers, future);
future.actionGet(TimeValue.timeValueSeconds(30));
/*
* We use a 3-minute timer because many of the cases can
* take 40 seconds in CI. Locally it's taking 9 seconds.
*/
future.actionGet(TimeValue.timeValueMinutes(3));
} finally {
terminate(threadPool);
}
Expand Down