Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Cases] Skipped tests no floating promises fixes #206718

Conversation

georgianaonoleata1904
Copy link
Contributor

@georgianaonoleata1904 georgianaonoleata1904 commented Jan 15, 2025

Closes #191185

Summary

  • un-skipped tests in the following modules:

  • x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts

  • x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts

  • x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts

@georgianaonoleata1904 georgianaonoleata1904 self-assigned this Jan 15, 2025
@georgianaonoleata1904 georgianaonoleata1904 added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 Feature:Cases Cases feature labels Jan 16, 2025
@georgianaonoleata1904 georgianaonoleata1904 marked this pull request as ready for review January 16, 2025 08:00
@georgianaonoleata1904 georgianaonoleata1904 requested a review from a team as a code owner January 16, 2025 08:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@umbopepato umbopepato self-requested a review January 16, 2025 09:20
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

Copy link
Member

@umbopepato umbopepato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #86 / machine learning - anomaly detection anomaly explorer with influencers with farequote based multi metric job Anomaly Swim Lane as embeddable attaches swim lane embeddable to a case

Metrics [docs]

✅ unchanged

History

cc @georgianaonoleata1904

@cnasikas
Copy link
Member

@georgianaonoleata1904 Could you please run the flaky test runner? @js-jankisalvi and @umbopepato can help with that.

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7735

[✅] x-pack/test/functional_with_es_ssl/apps/cases/group1/config.ts: 50/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7736

[✅] x-pack/test_serverless/functional/test_suites/observability/config.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/security/config.ts: 50/50 tests passed.

see run history

@georgianaonoleata1904 georgianaonoleata1904 merged commit 4f59641 into elastic:main Jan 17, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12824569019

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 17, 2025
…c#206718)

Closes elastic#191185

## Summary

- un-skipped tests in the following modules:

- ` x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts`
-
`x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts`
-
`x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts`

(cherry picked from commit 4f59641)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 17, 2025
…206718) (#207023)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Cases] Skipped tests no floating promises fixes
(#206718)](#206718)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgiana-Andreea
Onoleață","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-17T07:25:23Z","message":"[ResponseOps][Cases]
Skipped tests no floating promises fixes (#206718)\n\nCloses
https://github.com/elastic/kibana/issues/191185\r\n\r\n##
Summary\r\n\r\n- un-skipped tests in the following modules:\r\n\r\n- `
x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts`","sha":"4f59641f3a9bdf5060723474e64f10a48cfc666d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.18.0"],"title":"[ResponseOps][Cases]
Skipped tests no floating promises
fixes","number":206718,"url":"https://github.com/elastic/kibana/pull/206718","mergeCommit":{"message":"[ResponseOps][Cases]
Skipped tests no floating promises fixes (#206718)\n\nCloses
https://github.com/elastic/kibana/issues/191185\r\n\r\n##
Summary\r\n\r\n- un-skipped tests in the following modules:\r\n\r\n- `
x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts`","sha":"4f59641f3a9bdf5060723474e64f10a48cfc666d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206718","number":206718,"mergeCommit":{"message":"[ResponseOps][Cases]
Skipped tests no floating promises fixes (#206718)\n\nCloses
https://github.com/elastic/kibana/issues/191185\r\n\r\n##
Summary\r\n\r\n- un-skipped tests in the following modules:\r\n\r\n- `
x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts`","sha":"4f59641f3a9bdf5060723474e64f10a48cfc666d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps][Cases] skipped test after no-floating-promises fixes
6 participants