-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps][Cases] Skipped tests no floating promises fixes #206718
[ResponseOps][Cases] Skipped tests no floating promises fixes #206718
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
@georgianaonoleata1904 Could you please run the flaky test runner? @js-jankisalvi and @umbopepato can help with that. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7735[✅] x-pack/test/functional_with_es_ssl/apps/cases/group1/config.ts: 50/50 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7736[✅] x-pack/test_serverless/functional/test_suites/observability/config.ts: 50/50 tests passed. |
Starting backport for target branches: 8.x |
…c#206718) Closes elastic#191185 ## Summary - un-skipped tests in the following modules: - ` x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts` - `x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts` - `x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts` (cherry picked from commit 4f59641)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…206718) (#207023) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] Skipped tests no floating promises fixes (#206718)](#206718) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-17T07:25:23Z","message":"[ResponseOps][Cases] Skipped tests no floating promises fixes (#206718)\n\nCloses https://github.com/elastic/kibana/issues/191185\r\n\r\n## Summary\r\n\r\n- un-skipped tests in the following modules:\r\n\r\n- ` x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts`","sha":"4f59641f3a9bdf5060723474e64f10a48cfc666d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.18.0"],"title":"[ResponseOps][Cases] Skipped tests no floating promises fixes","number":206718,"url":"https://github.com/elastic/kibana/pull/206718","mergeCommit":{"message":"[ResponseOps][Cases] Skipped tests no floating promises fixes (#206718)\n\nCloses https://github.com/elastic/kibana/issues/191185\r\n\r\n## Summary\r\n\r\n- un-skipped tests in the following modules:\r\n\r\n- ` x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts`","sha":"4f59641f3a9bdf5060723474e64f10a48cfc666d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206718","number":206718,"mergeCommit":{"message":"[ResponseOps][Cases] Skipped tests no floating promises fixes (#206718)\n\nCloses https://github.com/elastic/kibana/issues/191185\r\n\r\n## Summary\r\n\r\n- un-skipped tests in the following modules:\r\n\r\n- ` x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts`\r\n-\r\n`x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts`","sha":"4f59641f3a9bdf5060723474e64f10a48cfc666d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
Closes #191185
Summary
un-skipped tests in the following modules:
x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts
x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts
x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts