[Discover] Add a default "All logs" temporary data view in the Observability Solution view

src/platform/packages/shared/kbn-discover-utils/src/__mocks__/logs_context_service.ts

@@ -10,5 +10,8 @@
 import { DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP, getLogsContextService } from '../data_types';
 
 export const createLogsContextServiceMock = () => {
-  return getLogsContextService([DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP]);
+  return getLogsContextService({
+    allLogsIndexPattern: 'logs-*',
+    allowedDataSources: [DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP],
+  });
 };

src/platform/packages/shared/kbn-discover-utils/src/data_types/logs/logs_context_service.ts

@@ -11,6 +11,7 @@ import { createRegExpPatternFrom, testPatternAgainstAllowedList } from '@kbn/dat
 import type { LogsDataAccessPluginStart } from '@kbn/logs-data-access-plugin/public';
 
 export interface LogsContextService {
+  getAllLogsIndexPattern(): string | undefined;
   isLogsIndexPattern(indexPattern: unknown): boolean;
 }
 
@@ -32,34 +33,45 @@ export const DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP = createRegExpPatternFrom
   'data'
 );
 
-export const createLogsContextService = async ({ logsDataAccess }: LogsContextServiceDeps) => {
+export const createLogsContextService = async ({
+  logsDataAccess,
+}: LogsContextServiceDeps): Promise<LogsContextService> => {
+  let allLogsIndexPattern: string | undefined;
   let logSources: string[] | undefined;
 
   if (logsDataAccess) {
     const logSourcesService = logsDataAccess.services.logSourcesService;
-    logSources = (await logSourcesService.getLogSources())
+    allLogsIndexPattern = (await logSourcesService.getLogSources())
       .map((logSource) => logSource.indexPattern)
-      .join(',') // TODO: Will be replaced by helper in: https://github.com/elastic/kibana/pull/192003
-      .split(',');
+      .join(','); // TODO: Will be replaced by helper in: https://github.com/elastic/kibana/pull/192003
+    logSources = allLogsIndexPattern.split(',');
   }
 
   const ALLOWED_LOGS_DATA_SOURCES = [
     DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP,
     ...(logSources ? logSources : []),
   ];
 
-  return getLogsContextService(ALLOWED_LOGS_DATA_SOURCES);
+  return getLogsContextService({
+    allLogsIndexPattern,
+    allowedDataSources: ALLOWED_LOGS_DATA_SOURCES,
+  });
 };
 
-export const getLogsContextService = (allowedDataSources: Array<string | RegExp>) => {
+export const getLogsContextService = ({
+  allLogsIndexPattern,
+  allowedDataSources,
+}: {
+  allLogsIndexPattern: string | undefined;
+  allowedDataSources: Array<string | RegExp>;
+}): LogsContextService => {
+  const getAllLogsIndexPattern = () => allLogsIndexPattern;
   const isLogsIndexPattern = (indexPattern: unknown) => {
     return (
       typeof indexPattern === 'string' &&
       testPatternAgainstAllowedList(allowedDataSources)(indexPattern)
     );
   };
 
-  return {
-    isLogsIndexPattern,
-  };
+  return { getAllLogsIndexPattern, isLogsIndexPattern };
 };

src/platform/packages/shared/kbn-es-query/index.ts

@@ -104,6 +104,7 @@ export {
   uniqFilters,
   unpinFilter,
   updateFilter,
+  updateFilterReferences,
   extractTimeFilter,
   extractTimeRange,
   convertRangeFilterToTimeRange,

src/platform/packages/shared/kbn-es-query/src/filters/helpers/index.ts

@@ -15,4 +15,5 @@ export * from './meta_filter';
 export * from './only_disabled';
 export * from './extract_time_filter';
 export * from './convert_range_filter';
+export * from './update_filter_references';
 export * from './types';

src/platform/packages/shared/kbn-es-query/src/filters/helpers/update_filter_references.ts

@@ -0,0 +1,30 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+import { Filter } from '..';
+
+export function updateFilterReferences(
+  filters: Filter[],
+  fromDataView: string,
+  toDataView: string | undefined
+) {
+  return (filters || []).map((filter) => {
+    if (filter.meta.index === fromDataView) {
+      return {
+        ...filter,
+        meta: {
+          ...filter.meta,
+          index: toDataView,
+        },
+      };
+    } else {
+      return filter;
+    }
+  });
+}

src/platform/packages/shared/kbn-es-query/src/filters/index.ts

@@ -31,6 +31,7 @@ export {
   extractTimeFilter,
   extractTimeRange,
   convertRangeFilterToTimeRange,
+  updateFilterReferences,
 } from './helpers';
 
 export {

src/platform/plugins/shared/discover/public/application/main/components/sidebar/discover_sidebar_responsive.test.tsx

@@ -34,6 +34,7 @@ import { buildDataTableRecord } from '@kbn/discover-utils';
 import type { DataTableRecord } from '@kbn/discover-utils/types';
 import type { DiscoverCustomizationId } from '../../../../customizations/customization_service';
 import { FieldListCustomization, SearchBarCustomization } from '../../../../customizations';
+import { InternalStateProvider } from '../../state_management/discover_internal_state_container';
 
 const mockSearchBarCustomization: SearchBarCustomization = {
   id: 'search_bar',
@@ -177,13 +178,13 @@ function getCompProps(options?: { hits?: DataTableRecord[] }): DiscoverSidebarRe
   };
 }
 
-function getAppStateContainer({ query }: { query?: Query | AggregateQuery }) {
-  const appStateContainer = getDiscoverStateMock({ isTimeBased: true }).appState;
-  appStateContainer.set({
+function getStateContainer({ query }: { query?: Query | AggregateQuery }) {
+  const stateContainer = getDiscoverStateMock({ isTimeBased: true });
+  stateContainer.appState.set({
     query: query ?? { query: '', language: 'lucene' },
     filters: [],
   });
-  return appStateContainer;
+  return stateContainer;
 }
 
 async function mountComponent(
@@ -192,7 +193,7 @@ async function mountComponent(
   services?: DiscoverServices
 ): Promise<ReactWrapper<DiscoverSidebarResponsiveProps>> {
   let comp: ReactWrapper<DiscoverSidebarResponsiveProps>;
-  const appState = getAppStateContainer(appStateParams);
+  const { appState, internalState } = getStateContainer(appStateParams);
   const mockedServices = services ?? createMockServices();
   mockedServices.data.dataViews.getIdsWithTitle = jest.fn(async () =>
     props.selectedDataView
@@ -208,7 +209,9 @@ async function mountComponent(
     comp = mountWithIntl(
       <KibanaContextProvider services={mockedServices}>
         <DiscoverAppStateProvider value={appState}>
-          <DiscoverSidebarResponsive {...props} />
+          <InternalStateProvider value={internalState}>
+            <DiscoverSidebarResponsive {...props} />
+          </InternalStateProvider>
         </DiscoverAppStateProvider>
       </KibanaContextProvider>
     );

src/platform/plugins/shared/discover/public/application/main/components/sidebar/discover_sidebar_responsive.tsx

@@ -37,6 +37,10 @@ import {
 import { useDiscoverCustomization } from '../../../../customizations';
 import { useAdditionalFieldGroups } from '../../hooks/sidebar/use_additional_field_groups';
 import { useIsEsqlMode } from '../../hooks/use_is_esql_mode';
+import {
+  selectDataViewsForPicker,
+  useInternalStateSelector,
+} from '../../state_management/discover_internal_state_container';
 
 const EMPTY_FIELD_COUNTS = {};
 
@@ -172,6 +176,8 @@ export function DiscoverSidebarResponsive(props: DiscoverSidebarResponsiveProps)
   );
   const selectedDataViewRef = useRef<DataView | null | undefined>(selectedDataView);
   const showFieldList = sidebarState.status !== DiscoverSidebarReducerStatus.INITIAL;
+  const { savedDataViews, managedDataViews, adHocDataViews } =
+    useInternalStateSelector(selectDataViewsForPicker);
 
   useEffect(() => {
     const subscription = props.documents$.subscribe((documentState) => {
@@ -326,6 +332,9 @@ export function DiscoverSidebarResponsive(props: DiscoverSidebarResponsiveProps)
       ) : (
         <DataViewPicker
           currentDataViewId={selectedDataView.id}
+          adHocDataViews={adHocDataViews}
+          managedDataViews={managedDataViews}
+          savedDataViews={savedDataViews}
           onChangeDataView={onChangeDataView}
           onAddField={createField}
           onDataViewCreated={createNewDataView}
@@ -338,7 +347,16 @@ export function DiscoverSidebarResponsive(props: DiscoverSidebarResponsiveProps)
         />
       )
     ) : null;
-  }, [selectedDataView, createNewDataView, onChangeDataView, createField, CustomDataViewPicker]);
+  }, [
+    selectedDataView,
+    CustomDataViewPicker,
+    adHocDataViews,
+    managedDataViews,
+    savedDataViews,
+    onChangeDataView,
+    createField,
+    createNewDataView,
+  ]);
 
   const onAddFieldToWorkspace = useCallback(
     (field: DataViewField) => {

src/platform/plugins/shared/discover/public/application/main/components/top_nav/discover_topnav.tsx

@@ -15,7 +15,10 @@ import { TextBasedLanguages } from '@kbn/esql-utils';
 import { DiscoverFlyouts, dismissAllFlyoutsExceptFor } from '@kbn/discover-utils';
 import { useSavedSearchInitial } from '../../state_management/discover_state_provider';
 import { ESQL_TRANSITION_MODAL_KEY } from '../../../../../common/constants';
-import { useInternalStateSelector } from '../../state_management/discover_internal_state_container';
+import {
+  selectDataViewsForPicker,
+  useInternalStateSelector,
+} from '../../state_management/discover_internal_state_container';
 import { useDiscoverServices } from '../../../../hooks/use_discover_services';
 import type { DiscoverStateContainer } from '../../state_management/discover_state';
 import { onSaveSearch } from './on_save_search';
@@ -49,9 +52,9 @@ export const DiscoverTopNav = ({
   const { dataViewEditor, navigation, dataViewFieldEditor, data, uiSettings, setHeaderActionMenu } =
     services;
   const query = useAppStateSelector((state) => state.query);
-  const adHocDataViews = useInternalStateSelector((state) => state.adHocDataViews);
+  const { savedDataViews, managedDataViews, adHocDataViews } =
+    useInternalStateSelector(selectDataViewsForPicker);
   const dataView = useInternalStateSelector((state) => state.dataView!);
-  const savedDataViews = useInternalStateSelector((state) => state.savedDataViews);
   const isESQLToDataViewTransitionModalVisible = useInternalStateSelector(
     (state) => state.isESQLToDataViewTransitionModalVisible
   );
@@ -180,9 +183,7 @@ export const DiscoverTopNav = ({
 
   const dataViewPickerProps: DataViewPickerProps = useMemo(() => {
     const isESQLModeEnabled = uiSettings.get(ENABLE_ESQL);
-    const supportedTextBasedLanguages: DataViewPickerProps['textBasedLanguages'] = isESQLModeEnabled
-      ? [TextBasedLanguages.ESQL]
-      : [];
+    const supportedTextBasedLanguages = isESQLModeEnabled ? [TextBasedLanguages.ESQL] : [];
 
     return {
       trigger: {
@@ -197,6 +198,7 @@ export const DiscoverTopNav = ({
       onChangeDataView: stateContainer.actions.onChangeDataView,
       textBasedLanguages: supportedTextBasedLanguages,
       adHocDataViews,
+      managedDataViews,
       savedDataViews,
       onEditDataView: stateContainer.actions.onDataViewEdited,
     };
@@ -205,6 +207,7 @@ export const DiscoverTopNav = ({
     addField,
     createNewDataView,
     dataView,
+    managedDataViews,
     savedDataViews,
     stateContainer,
     uiSettings,

src/platform/plugins/shared/discover/public/application/main/data_fetching/fetch_all.test.ts

@@ -72,6 +72,7 @@ describe('test fetchAll', () => {
         isDataViewLoading: false,
         savedDataViews: [],
         adHocDataViews: [],
+        defaultProfileAdHocDataViewIds: [],
         expandedDoc: undefined,
         customFilters: [],
         overriddenVisContextAfterInvalidation: undefined,
@@ -265,6 +266,7 @@ describe('test fetchAll', () => {
         isDataViewLoading: false,
         savedDataViews: [],
         adHocDataViews: [],
+        defaultProfileAdHocDataViewIds: [],
         expandedDoc: undefined,
         customFilters: [],
         overriddenVisContextAfterInvalidation: undefined,
@@ -389,6 +391,7 @@ describe('test fetchAll', () => {
           isDataViewLoading: false,
           savedDataViews: [],
           adHocDataViews: [],
+          defaultProfileAdHocDataViewIds: [],
           expandedDoc: undefined,
           customFilters: [],
           overriddenVisContextAfterInvalidation: undefined,