[Discover] Add a default "All logs" temporary data view in the Observability Solution view

src/platform/packages/shared/kbn-discover-utils/src/__mocks__/logs_context_service.ts

@@ -10,5 +10,8 @@
 import { DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP, getLogsContextService } from '../data_types';
 
 export const createLogsContextServiceMock = () => {
-  return getLogsContextService([DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP]);
+  return getLogsContextService({
+    allLogsIndexPattern: 'logs-*',
+    allowedDataSources: [DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP],
+  });
 };

src/platform/packages/shared/kbn-discover-utils/src/data_types/logs/logs_context_service.ts

@@ -11,6 +11,7 @@ import { createRegExpPatternFrom, testPatternAgainstAllowedList } from '@kbn/dat
 import type { LogsDataAccessPluginStart } from '@kbn/logs-data-access-plugin/public';
 
 export interface LogsContextService {
+  getAllLogsIndexPattern(): string | undefined;
   isLogsIndexPattern(indexPattern: unknown): boolean;
 }
 
@@ -32,34 +33,45 @@ export const DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP = createRegExpPatternFrom
   'data'
 );
 
-export const createLogsContextService = async ({ logsDataAccess }: LogsContextServiceDeps) => {
+export const createLogsContextService = async ({
+  logsDataAccess,
+}: LogsContextServiceDeps): Promise<LogsContextService> => {
+  let allLogsIndexPattern: string | undefined;
   let logSources: string[] | undefined;
 
   if (logsDataAccess) {
     const logSourcesService = logsDataAccess.services.logSourcesService;
-    logSources = (await logSourcesService.getLogSources())
+    allLogsIndexPattern = (await logSourcesService.getLogSources())
       .map((logSource) => logSource.indexPattern)
-      .join(',') // TODO: Will be replaced by helper in: https://github.com/elastic/kibana/pull/192003
-      .split(',');
+      .join(','); // TODO: Will be replaced by helper in: https://github.com/elastic/kibana/pull/192003
+    logSources = allLogsIndexPattern.split(',');
   }
 
   const ALLOWED_LOGS_DATA_SOURCES = [
     DEFAULT_ALLOWED_LOGS_BASE_PATTERNS_REGEXP,
     ...(logSources ? logSources : []),
   ];
 
-  return getLogsContextService(ALLOWED_LOGS_DATA_SOURCES);
+  return getLogsContextService({
+    allLogsIndexPattern,
+    allowedDataSources: ALLOWED_LOGS_DATA_SOURCES,
+  });
 };
 
-export const getLogsContextService = (allowedDataSources: Array<string | RegExp>) => {
+export const getLogsContextService = ({
+  allLogsIndexPattern,
+  allowedDataSources,
+}: {
+  allLogsIndexPattern: string | undefined;
+  allowedDataSources: Array<string | RegExp>;
+}): LogsContextService => {
+  const getAllLogsIndexPattern = () => allLogsIndexPattern;
   const isLogsIndexPattern = (indexPattern: unknown) => {
     return (
       typeof indexPattern === 'string' &&
       testPatternAgainstAllowedList(allowedDataSources)(indexPattern)
     );
   };
 
-  return {
-    isLogsIndexPattern,
-  };
+  return { getAllLogsIndexPattern, isLogsIndexPattern };
 };

src/platform/plugins/shared/discover/public/application/main/data_fetching/fetch_all.test.ts

@@ -72,6 +72,7 @@ describe('test fetchAll', () => {
         isDataViewLoading: false,
         savedDataViews: [],
         adHocDataViews: [],
+        defaultProfileAdHocDataViewIds: [],
         expandedDoc: undefined,
         customFilters: [],
         overriddenVisContextAfterInvalidation: undefined,
@@ -265,6 +266,7 @@ describe('test fetchAll', () => {
         isDataViewLoading: false,
         savedDataViews: [],
         adHocDataViews: [],
+        defaultProfileAdHocDataViewIds: [],
         expandedDoc: undefined,
         customFilters: [],
         overriddenVisContextAfterInvalidation: undefined,
@@ -389,6 +391,7 @@ describe('test fetchAll', () => {
           isDataViewLoading: false,
           savedDataViews: [],
           adHocDataViews: [],
+          defaultProfileAdHocDataViewIds: [],
           expandedDoc: undefined,
           customFilters: [],
           overriddenVisContextAfterInvalidation: undefined,

src/platform/plugins/shared/discover/public/application/main/discover_main_route.test.tsx

@@ -22,6 +22,7 @@ import {
 } from '../../customizations/customization_service';
 import { DiscoverTopNavInline } from './components/top_nav/discover_topnav_inline';
 import { mockCustomizationContext } from '../../customizations/__mocks__/customization_context';
+import { DataView, DataViewSpec } from '@kbn/data-views-plugin/common';
 
 let mockCustomizationService: DiscoverCustomizationService | undefined;
 
@@ -43,6 +44,7 @@ jest.mock('./discover_main_app', () => {
 });
 
 let mockRootProfileLoading = false;
+let mockDefaultAdHocDataViews: DataViewSpec[] = [];
 
 jest.mock('../../context_awareness', () => {
   const originalModule = jest.requireActual('../../context_awareness');
@@ -51,6 +53,7 @@ jest.mock('../../context_awareness', () => {
     useRootProfile: () => ({
       rootProfileLoading: mockRootProfileLoading,
       AppWrapper: ({ children }: { children: ReactNode }) => <>{children}</>,
+      getDefaultAdHocDataViews: () => mockDefaultAdHocDataViews,
     }),
   };
 });
@@ -59,6 +62,7 @@ describe('DiscoverMainRoute', () => {
   beforeEach(() => {
     mockCustomizationService = createCustomizationService();
     mockRootProfileLoading = false;
+    mockDefaultAdHocDataViews = [];
   });
 
   test('renders the main app when hasESData=true & hasUserDataView=true ', async () => {
@@ -70,6 +74,16 @@ describe('DiscoverMainRoute', () => {
     });
   });
 
+  test('renders the main app when ad hoc data views exist', async () => {
+    mockDefaultAdHocDataViews = [{ id: 'test', title: 'test' }];
+    const component = mountComponent(true, false);
+
+    await waitFor(() => {
+      component.update();
+      expect(component.find(DiscoverMainApp).exists()).toBe(true);
+    });
+  });
+
   test('renders no data page when hasESData=false & hasUserDataView=false', async () => {
     const component = mountComponent(false, false);
 
@@ -158,6 +172,7 @@ function getServicesMock(hasESData = true, hasUserDataView = true) {
     hasUserDataView: jest.fn(() => Promise.resolve(hasUserDataView)),
     hasDataView: jest.fn(() => Promise.resolve(true)),
   };
+  dataViewsMock.create = jest.fn((spec) => Promise.resolve(spec as unknown as DataView));
   discoverServiceMock.core.http.get = jest.fn().mockResolvedValue({});
   return discoverServiceMock;
 }

src/platform/plugins/shared/discover/public/application/main/discover_main_route.tsx

@@ -41,7 +41,7 @@ import {
 import { DiscoverTopNavInline } from './components/top_nav/discover_topnav_inline';
 import { DiscoverStateContainer, LoadParams } from './state_management/discover_state';
 import { DataSourceType, isDataSourceType } from '../../../common/data_sources';
-import { useRootProfile } from '../../context_awareness';
+import { useDefaultAdHocDataViews, useRootProfile } from '../../context_awareness';
 
 const DiscoverMainAppMemoized = memo(DiscoverMainApp);
 
@@ -134,14 +134,21 @@ export function DiscoverMainRoute({
           stateContainer.actions.loadDataViewList(),
         ]);
 
-        if (!hasUserDataViewValue || !defaultDataViewExists) {
+        const hasAdHocDataViews = stateContainer.internalState.getState().adHocDataViews.length > 0;
+
+        if (
+          (!hasUserDataViewValue || !defaultDataViewExists) &&
+          (!hasAdHocDataViews || !hasESDataValue)
+        ) {
           setNoDataState({
             showNoDataPage: true,
             hasESData: hasESDataValue,
             hasUserDataView: hasUserDataViewValue,
           });
+
           return false;
         }
+
         return true;
       } catch (e) {
         setError(e);
@@ -228,22 +235,45 @@ export function DiscoverMainRoute({
     ]
   );
 
+  const rootProfileState = useRootProfile();
+  const { initializeProfileDataViews } = useDefaultAdHocDataViews({
+    stateContainer,
+    rootProfileState,
+  });
+
   useEffect(() => {
-    if (!isCustomizationServiceInitialized) return;
-    setLoading(true);
-    setNoDataState({
-      hasESData: false,
-      hasUserDataView: false,
-      showNoDataPage: false,
-    });
-    setError(undefined);
-    if (savedSearchId) {
-      loadSavedSearch();
-    } else {
-      // restore the previously selected data view for a new state (when a saved search was open)
-      loadSavedSearch(getLoadParamsForNewSearch(stateContainer));
+    if (!isCustomizationServiceInitialized || rootProfileState.rootProfileLoading) {
+      return;
     }
-  }, [isCustomizationServiceInitialized, loadSavedSearch, savedSearchId, stateContainer]);
+
+    const load = async () => {
+      setLoading(true);
+      setNoDataState({
+        hasESData: false,
+        hasUserDataView: false,
+        showNoDataPage: false,
+      });
+      setError(undefined);
+
+      await initializeProfileDataViews();
+
+      if (savedSearchId) {
+        await loadSavedSearch();
+      } else {
+        // restore the previously selected data view for a new state (when a saved search was open)
+        await loadSavedSearch(getLoadParamsForNewSearch(stateContainer));
+      }
+    };
+
+    load();
+  }, [
+    initializeProfileDataViews,
+    isCustomizationServiceInitialized,
+    loadSavedSearch,
+    rootProfileState.rootProfileLoading,
+    savedSearchId,
+    stateContainer,
+  ]);
 
   // secondary fetch: in case URL is set to `/`, used to reset to 'new' state, keeping the current data view
   useUrl({
@@ -340,8 +370,6 @@ export function DiscoverMainRoute({
     stateContainer,
   ]);
 
-  const rootProfileState = useRootProfile();
-
   if (error) {
     return <DiscoverError error={error} />;
   }

src/platform/plugins/shared/discover/public/application/main/state_management/discover_app_state_container.test.ts

@@ -46,6 +46,7 @@ describe('Test discover app state container', () => {
     savedSearchState = getSavedSearchContainer({
       services: discoverServiceMock,
       globalStateContainer: getDiscoverGlobalStateContainer(stateStorage),
+      internalStateContainer: internalState,
     });
   });
 

src/platform/plugins/shared/discover/public/application/main/state_management/discover_internal_state_container.ts

@@ -28,6 +28,7 @@ export interface InternalState {
   isDataViewLoading: boolean;
   savedDataViews: DataViewListItem[];
   adHocDataViews: DataView[];
+  defaultProfileAdHocDataViewIds: string[];
   expandedDoc: DataTableRecord | undefined;
   customFilters: Filter[];
   overriddenVisContextAfterInvalidation: UnifiedHistogramVisContext | {} | undefined; // it will be used during saved search saving
@@ -46,10 +47,12 @@ export interface InternalStateTransitions {
   setIsDataViewLoading: (state: InternalState) => (isLoading: boolean) => InternalState;
   setSavedDataViews: (state: InternalState) => (dataView: DataViewListItem[]) => InternalState;
   setAdHocDataViews: (state: InternalState) => (dataViews: DataView[]) => InternalState;
+  setDefaultProfileAdHocDataViews: (
+    state: InternalState
+  ) => (dataViews: DataView[]) => InternalState;
   appendAdHocDataViews: (
     state: InternalState
   ) => (dataViews: DataView | DataView[]) => InternalState;
-  removeAdHocDataViewById: (state: InternalState) => (id: string) => InternalState;
   replaceAdHocDataViewWithId: (
     state: InternalState
   ) => (id: string, dataView: DataView) => InternalState;
@@ -90,6 +93,7 @@ export function getInternalStateContainer() {
       dataView: undefined,
       isDataViewLoading: false,
       adHocDataViews: [],
+      defaultProfileAdHocDataViewIds: [],
       savedDataViews: [],
       expandedDoc: undefined,
       customFilters: [],
@@ -126,6 +130,22 @@ export function getInternalStateContainer() {
         ...prevState,
         adHocDataViews: newAdHocDataViewList,
       }),
+      setDefaultProfileAdHocDataViews:
+        (prevState: InternalState) => (defaultProfileAdHocDataViews: DataView[]) => {
+          const adHocDataViews = prevState.adHocDataViews
+            .filter((dataView) => !prevState.defaultProfileAdHocDataViewIds.includes(dataView.id!))
+            .concat(defaultProfileAdHocDataViews);
+
+          const defaultProfileAdHocDataViewIds = defaultProfileAdHocDataViews.map(
+            (dataView) => dataView.id!
+          );
+
+          return {
+            ...prevState,
+            adHocDataViews,
+            defaultProfileAdHocDataViewIds,
+          };
+        },
       appendAdHocDataViews:
         (prevState: InternalState) => (dataViewsAdHoc: DataView | DataView[]) => {
           // check for already existing data views
@@ -142,17 +162,24 @@ export function getInternalStateContainer() {
             adHocDataViews: prevState.adHocDataViews.concat(dataViewsAdHoc),
           };
         },
-      removeAdHocDataViewById: (prevState: InternalState) => (id: string) => ({
-        ...prevState,
-        adHocDataViews: prevState.adHocDataViews.filter((dataView) => dataView.id !== id),
-      }),
       replaceAdHocDataViewWithId:
-        (prevState: InternalState) => (prevId: string, newDataView: DataView) => ({
-          ...prevState,
-          adHocDataViews: prevState.adHocDataViews.map((dataView) =>
-            dataView.id === prevId ? newDataView : dataView
-          ),
-        }),
+        (prevState: InternalState) => (prevId: string, newDataView: DataView) => {
+          let defaultProfileAdHocDataViewIds = prevState.defaultProfileAdHocDataViewIds;
+
+          if (defaultProfileAdHocDataViewIds.includes(prevId)) {
+            defaultProfileAdHocDataViewIds = defaultProfileAdHocDataViewIds.map((id) =>
+              id === prevId ? newDataView.id! : id
+            );
+          }
+
+          return {
+            ...prevState,
+            adHocDataViews: prevState.adHocDataViews.map((dataView) =>
+              dataView.id === prevId ? newDataView : dataView
+            ),
+            defaultProfileAdHocDataViewIds,
+          };
+        },
       setExpandedDoc: (prevState: InternalState) => (expandedDoc: DataTableRecord | undefined) => ({
         ...prevState,
         expandedDoc,