[Security Solution] Adds prebuilt rule customization cypress tests #212170
+388
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplumlee
added
test
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
banderror
force-pushed
the
rule-customization-cypress-tests
branch
from
d3f73f8 to
6799dd9
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @dplumlee |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7925[✅] Security Solution Rule Management - Prebuilt Rules - Cypress: 50/50 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7926[✅] [Serverless] Security Solution Rule Management - Prebuilt Rules - Cypress: 50/50 tests passed. |
12 tasks
banderror
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
I reviewed the changes, and this test coverage makes sense to me.
Further improvements I'm going to do in follow-up PRs:
- Make sure that the coverage is comprehensive. Right away I'm missing tests for some scenarios, such as editing the Author and License fields.
- Optimize the test setup. Some "read-only" checks could share the same data set up only once for all tests in a group.
- Split the tests into several files: one for navigation, one for bulk actions, one for the badge, etc.
- Probably something else that I'm missing at the moment.
The Flaky Test Runner looks satisfied, so I'm good with merging 👍
Comment on lines
+272
to
+279
| describe('calculating the Modified badge', () => { | ||
| it('modified badge should appear on the rule details page when prebuilt rule is customized', function () { | ||
| patchRule('rule_1', { name: 'Customized prebuilt rule' }); // We want to make this a customized prebuilt rule | ||
| visitRulesManagementTable(); | ||
|
|
||
| cy.get(RULE_NAME).contains('Customized prebuilt rule').click(); | ||
| expectModifiedBadgeToBeDisplayed(); // Expect modified badge to be displayed | ||
| }); |
There was a problem hiding this comment.
I think for all these tests for the badge we should have a single, common setup that would create all the needed rules, and then in each test we'd be just opening the right pages and checking the badge. There's no need to re-setup each test from scratch.
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…sts (#212170) (#212297) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Adds prebuilt rule customization cypress tests (#212170)](#212170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:35:21Z","message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization cypress tests","number":212170,"url":"https://github.com/elastic/kibana/pull/212170","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212170","number":212170,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…sts (#212170) (#212296) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule customization cypress tests (#212170)](#212170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:35:21Z","message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization cypress tests","number":212170,"url":"https://github.com/elastic/kibana/pull/212170","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212170","number":212170,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…ests (#212170) (#212295) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Adds prebuilt rule customization cypress tests (#212170)](#212170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:35:21Z","message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization cypress tests","number":212170,"url":"https://github.com/elastic/kibana/pull/212170","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212170","number":212170,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 25, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…sts (elastic#212170) (elastic#212296) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule customization cypress tests (elastic#212170)](elastic#212170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:35:21Z","message":"[Security Solution] Adds prebuilt rule customization cypress tests (elastic#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization cypress tests","number":212170,"url":"https://github.com/elastic/kibana/pull/212170","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (elastic#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212170","number":212170,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (elastic#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #202068
Summary
Adds tests in accordance to #204888
Follow-up to #207016
Adds cypress tests for the prebuilt rule customization features
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.