Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Refactor Discover initialization flow #213501

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

[Discover] Refactor Discover initialization flow #213501

wants to merge 17 commits into from

Conversation

davismcphee
Copy link
Contributor

Summary

WIP.

Resolves #213305.

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Project:OneDiscover Enrich Discover with contextual awareness backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Mar 6, 2025
@davismcphee davismcphee self-assigned this Mar 6, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 6, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@davismcphee davismcphee mentioned this pull request Mar 6, 2025
Closed
9 tasks
@davismcphee davismcphee force-pushed the discover-state-refactor branch from 638efa9 to e357c8c Compare March 7, 2025 20:36
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 8, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group6.ts / discover Discover CSV Export Generate CSV: new search generates a report from a new search with data: default
  • [job] [logs] FTR Configs #38 / discover Discover CSV Export Generate CSV: new search generates a report from a new search with data: default
  • [job] [logs] FTR Configs #44 / discover Discover CSV Export Generate CSV: new search generates a report from a new search with data: default
  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group6.ts / discover Discover CSV Export Generate CSV: new search generates a report from a new search with data: default
  • [job] [logs] FTR Configs #38 / discover Discover CSV Export Generate CSV: new search generates a report from a new search with data: default
  • [job] [logs] FTR Configs #44 / discover Discover CSV Export Generate CSV: new search generates a report from a new search with data: default
  • [job] [logs] FTR Configs #13 / discover feature controls discover feature controls security global discover read-only privileges should allow for copying the snapshot URL
  • [job] [logs] FTR Configs #13 / discover feature controls discover feature controls security global discover read-only privileges should allow for copying the snapshot URL
  • [job] [logs] FTR Configs #103 / discover/context_awareness extension getCellRenderers data view mode root profile should render custom @timestamp
  • [job] [logs] FTR Configs #103 / discover/context_awareness extension getCellRenderers data view mode root profile should render custom @timestamp
  • [job] [logs] FTR Configs #15 / discover/context_awareness extension getDefaultAdHocDataViews fallback behaviour should fall back to the profile data view when no other data views are available
  • [job] [logs] FTR Configs #15 / discover/context_awareness extension getDefaultAdHocDataViews fallback behaviour should fall back to the profile data view when no other data views are available
  • [job] [logs] FTR Configs #15 / discover/esql discover esql columns should render custom columns for non-transformational commands correctly
  • [job] [logs] FTR Configs #15 / discover/esql discover esql columns should render custom columns for non-transformational commands correctly
  • [job] [logs] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group5.ts / discover/group1 discover test query should show correct time range string by timepicker
  • [job] [logs] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group5.ts / discover/group1 discover test query should show correct time range string by timepicker
  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group1 discover test query should show correct time range string by timepicker
  • [job] [logs] FTR Configs #107 / discover/group1 discover test query should show correct time range string by timepicker
  • [job] [logs] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group5.ts / discover/group1 discover test query should show correct time range string by timepicker
  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group1 discover test query should show correct time range string by timepicker
  • [job] [logs] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group5.ts / discover/group1 discover test query should show correct time range string by timepicker
  • [job] [logs] FTR Configs #107 / discover/group1 discover test query should show correct time range string by timepicker
  • [job] [logs] FTR Configs #34 / discover/group2/data_grid1 discover data grid context tests navigates to context view from embeddable
  • [job] [logs] FTR Configs #34 / discover/group2/data_grid1 discover data grid context tests navigates to context view from embeddable
  • [job] [logs] FTR Configs #22 / discover/group2/data_grid2 discover data grid footer time field with date nano type should work for date nanos too
  • [job] [logs] FTR Configs #22 / discover/group2/data_grid2 discover data grid footer time field with date nano type should work for date nanos too
  • [job] [logs] FTR Configs #48 / discover/group2/data_grid3 discover data grid row selection can copy selected rows as JSON
  • [job] [logs] FTR Configs #48 / discover/group2/data_grid3 discover data grid row selection can copy selected rows as JSON
  • [job] [logs] test/functional/apps/discover/group3/config.ts / discover/group3 discover request counts ES|QL mode should send no more than 3 requests for saved search changes
  • [job] [logs] test/functional/apps/discover/group3/config.ts / discover/group3 discover request counts ES|QL mode should send no more than 3 requests for saved search changes
  • [job] [logs] FTR Configs #99 / discover/group4 discover uses fields API test should correctly display documents
  • [job] [logs] FTR Configs #99 / discover/group4 discover uses fields API test should correctly display documents
  • [job] [logs] FTR Configs #53 / discover/group5 shared links shared links with state in query permalink should load snapshot URL with empty sort param correctly
  • [job] [logs] FTR Configs #53 / discover/group5 shared links shared links with state in query permalink should load snapshot URL with empty sort param correctly
  • [job] [logs] FTR Configs #10 / discover/group7 discover new search action should work correctly for a saved search in data view mode
  • [job] [logs] FTR Configs #10 / discover/group7 discover new search action should work correctly for a saved search in data view mode
  • [job] [logs] FTR Configs #62 / management scripted fields creating and using Painless numeric scripted fields discover scripted field should see scripted field value in Discover
  • [job] [logs] FTR Configs #62 / management scripted fields creating and using Painless numeric scripted fields discover scripted field should see scripted field value in Discover
  • [job] [logs] FTR Configs #42 / serverless search UI default dataView should show discover but with no data
  • [job] [logs] FTR Configs #42 / serverless search UI default dataView should show discover but with no data

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 1187 1190 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 921.6KB 930.3KB +8.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
discover 29 30 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 44.3KB 44.4KB +150.0B

History

cc @davismcphee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davismcphee davismcphee

Labels
backport:version Backport to applied version labels Project:OneDiscover Enrich Discover with contextual awareness release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Refactor Discover initialization flow
2 participants
@davismcphee @elasticmachine