Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new properties in posthog UTD reports #4020

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 11, 2024

Add a few new properties to the UTD reports we send to Posthog.

Part of element-hq/element-meta#2582

Requires matrix-org/matrix-rust-sdk#4404.

Signed-off-by: Richard van der Hoff <[email protected]>

Tests

  • Receive a UTD
  • check the logging looks plausible

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 15

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

Add a few new properties to the UTD reports we send to Posthog.
@richvdh richvdh added the PR-Change For updates to an existing feature label Dec 11, 2024
@bmarty bmarty changed the base branch from develop to renovate/org.matrix.rustcomponents-sdk-android-0.x December 11, 2024 23:31
@bmarty bmarty changed the base branch from renovate/org.matrix.rustcomponents-sdk-android-0.x to develop December 11, 2024 23:32
@bmarty
Copy link
Member

bmarty commented Dec 12, 2024

Hello @richvdh, #4024 has been merged, I think it contains what you need for this PR. You will have to update the tests and probably add some (see the modified files in #4024). Let me know if you need anything!

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CmwBbr

Copy link

sonarcloud bot commented Dec 12, 2024

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (a665517) to head (f29dd29).
Report is 63 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4020   +/-   ##
========================================
  Coverage    83.01%   83.01%           
========================================
  Files         1845     1845           
  Lines        47699    47699           
  Branches      5632     5632           
========================================
  Hits         39595    39595           
  Misses        6108     6108           
  Partials      1996     1996           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richvdh richvdh marked this pull request as ready for review December 12, 2024 13:00
@richvdh richvdh requested a review from a team as a code owner December 12, 2024 13:00
@richvdh richvdh requested review from bmarty and removed request for a team December 12, 2024 13:00
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

eventLocalAgeMillis = info.eventLocalAgeMillis.toInt(),
userTrustsOwnIdentity = info.userTrustsOwnIdentity,
isFederated = info.ownHomeserver != info.senderHomeserver,
isMatrixDotOrg = info.ownHomeserver == "matrix.org",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check but are you sure that the ownHomeserver will be "matrix.org"? This looks more like a domain. Maybe a naming issue SDK side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite follow. The name of the matrix.org homeserver is matrix.org.

This matches the behaviour on Element Web: https://github.com/element-hq/element-web/blob/edaf9773c02e71b20eedebbd9619ff8a2b2e4cf2/src/DecryptionFailureTracker.ts#L322.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks!

@richvdh richvdh added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 13, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 13, 2024
@bmarty bmarty merged commit c36ac5d into develop Dec 13, 2024
28 of 30 checks passed
@bmarty bmarty deleted the rav/more_posthog_props branch December 13, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants