-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new properties in posthog UTD reports #4020
Conversation
Add a few new properties to the UTD reports we send to Posthog.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4020 +/- ##
========================================
Coverage 83.01% 83.01%
========================================
Files 1845 1845
Lines 47699 47699
Branches 5632 5632
========================================
Hits 39595 39595
Misses 6108 6108
Partials 1996 1996 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
eventLocalAgeMillis = info.eventLocalAgeMillis.toInt(), | ||
userTrustsOwnIdentity = info.userTrustsOwnIdentity, | ||
isFederated = info.ownHomeserver != info.senderHomeserver, | ||
isMatrixDotOrg = info.ownHomeserver == "matrix.org", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check but are you sure that the ownHomeserver
will be "matrix.org"? This looks more like a domain. Maybe a naming issue SDK side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite follow. The name of the matrix.org
homeserver is matrix.org
.
This matches the behaviour on Element Web: https://github.com/element-hq/element-web/blob/edaf9773c02e71b20eedebbd9619ff8a2b2e4cf2/src/DecryptionFailureTracker.ts#L322.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks!
Add a few new properties to the UTD reports we send to Posthog.
Part of element-hq/element-meta#2582
Requires matrix-org/matrix-rust-sdk#4404.
Signed-off-by: Richard van der Hoff <[email protected]>
Tests
Tested devices
Checklist