-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spurious external change warnings #1354
Conversation
As this issue depends on semi-random events order and timing, it was tested by using it for intensive coding for a while without spurious warnings. |
Converting to draft as started getting unexplained closing of Code. Investigating. |
OK, its to do with a certain file causing problems with the Symbol Pane - nothing to do with this PR. |
It could be something to do with this although it only seems to affect a certain file - need to investigate effect of changes in timing of autosave on the outline plugin. Seems to sometimes only partially parse the file - or not at all. |
Now confident that the outline issue is unrelated to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to repro for like 5-10 minutes but it wasn't happening. The code seems to make sense though. If you really want me to try and see if it works, I can keep testing but for now I approve.
@zeebok Thanks for testing. Its one of those annoying timing issues that is not always reproducible. I'd guess it might be more likely to happen with a large document that takes a longer time to status check. |
I think I'll merge this but wait a while for further dog-fooding before finalizing the release. |
Since recent changes to external change handling it was noticed that spurious warnings of external changes were produced while editing. This was traced to file status checking not completing before autosaving commenced because source loading is asynchronous.
This PR makes sure file status checking completes before saving starts when autosaving.