-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(init): init from template #10
Conversation
Reviewer's Guide by SourceryThis pull request initializes the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
…o be changed to account for project name width
…ing .cruft.json
@uniqueg Please add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss at the meeting with @psankhe28
Signed-off-by: Prati28 <[email protected]>
@psankhe28 I meant add it from teh readme from main, I don't think you need to remove anything from the readme. I meant adding there instructions
If they are not needed or have changed, ig better revert it, unless ofc you have a reason. |
This reverts commit 93a6ca3.
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
tus-storagehandler
with cookiecutter
Hey @psankhe28 spell check failed, spelling for synopsis is wrong 😅 @uniqueg have up not added the token or there is something wrong with ci? |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Indeed, BUT, @JaeAeich: I don't understand the It seems to me that either the Action that uses Or the instructions should instead describe how (and with what exact permissions) Do you want to test and change that before or after merging this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, despite #10 (comment), as we can always fix the update.yaml
later, if necessary.
Use cookiecutter to initialize the project.
Summary by Sourcery
Initialize the
tus-storagehandler
project using the cookiecutter template. This includes setting up the project structure, adding CI/CD workflows, documentation, initial tests, and various configuration files for code quality and security checks.CI:
Deployment:
Documentation:
Tests:
Chores: