Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed task monitor and enabled background data save flow #251

Merged
merged 4 commits into from
Dec 31, 2022
Merged

Removed task monitor and enabled background data save flow #251

merged 4 commits into from
Dec 31, 2022

Conversation

kushagra189
Copy link
Contributor

@kushagra189 kushagra189 commented Nov 26, 2022 •
edited
Loading

This PR intends to remove parallel celery task monitoring.
Fixes #250

@kushagra189 kushagra189 requested a review from uniqueg December 11, 2022 14:18
uniqueg
uniqueg requested changes Dec 29, 2022
View reviewed changes
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minus the very minor issues I added, this looks pretty good to me. I would have to see how it plays out in the main migration branch, so I would propose that you fix these minor issues and then we merge. And then we see where we are with some tests :)

cwl_wes/custom_config.py Outdated Show resolved Hide resolved
cwl_wes/custom_config.py Show resolved Hide resolved
cwl_wes/custom_config.py Show resolved Hide resolved
cwl_wes/custom_config.py Outdated Show resolved Hide resolved
cwl_wes/custom_config.py Outdated Show resolved Hide resolved
cwl_wes/custom_config.py Show resolved Hide resolved
cwl_wes/custom_config.py Show resolved Hide resolved
cwl_wes/custom_config.py Outdated Show resolved Hide resolved
cwl_wes/tasks/tasks/run_workflow.py Outdated Show resolved Hide resolved
@uniqueg uniqueg self-requested a review December 31, 2022 19:02
@uniqueg uniqueg merged commit 8b138a0 into maintenance/migrate_foca_version Dec 31, 2022
@uniqueg uniqueg deleted the maintenance/remove_listener_log_implementation branch December 31, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniqueg uniqueg uniqueg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kushagra189 @uniqueg