-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add type checks #88
Conversation
@uniqueg Is this good (in right dir)? I still need to narrow it down a little as I have ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JaeAeich. Quite a number of comments, but I guess they are mostly small things (except perhaps the .wes_endpoint
validation, which, however, is not necessary).
Hey @uniqueg, unfortunately
Where
yeah that mean I gotta do it in two place ie, for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Just one question I still have (but maybe I'm missing something)
Looks fine to me, not too messy :) |
Sorry, only saw now that you were not ready for review. Gave you one anyway 😆 But it seems to me that you addressed at least most of my previous issues. Please make sure to resolve the corresponding conversations so that we can better keep track of what's still left to do. |
8e1e672
to
8e1a4e6
Compare
I am disabling all error for missing imports, when |
c70f0f9
to
3e19017
Compare
@uniqueg Please review the PR. I have made the requested changes 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thanks a lot @JaeAeich :)
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
This PR add type checking using mypy as stated in issue #77
Closing issues
Fixes issue - #77