upgrade to webpack 2 #53
Conversation
package.json
Outdated
| "webpack-merge": "^2.4.0" | ||
| "webpack": "^2.2.1", | ||
| "webpack-dev-server": "^2.4.1", | ||
| "webpack-merge": "^3.0.0" |
There was a problem hiding this comment.
About 2 hours ago 4.0.0 of webpack-merge came out ^^
.gitignore
Outdated
| @@ -2,3 +2,12 @@ elm-stuff/ | |||
| node_modules/ | |||
| tmp/ | |||
| dist/ | |||
|
|
|||
| #IDE configuration files | |||
There was a problem hiding this comment.
I'm not a huge fan of IDE and OS specific stuff in project's .gitignore files. Imo this sort of things should be handled in a global .gitignore per machine. But after all that's just personal taste, so definitely up for discussion.
There was a problem hiding this comment.
agree :) It is better to enable global .gitignore with command git config --global core.excludesfile ~/.gitignore_global.
|
Apart from that: looks good to me 😀 |
| { | ||
| test: /\.(eot|ttf|woff|woff2|svg)$/, | ||
| loader: 'file-loader' | ||
| use: 'file-loader' |
There was a problem hiding this comment.
I think this should still be loader. Check the // Do not use "use" here comment in the code block at https://webpack.js.org/guides/migrating/#module-loaders-is-now-module-rules
| { | ||
| test: /\.elm$/, | ||
| exclude: [/elm-stuff/, /node_modules/], | ||
| loader: 'elm-webpack' | ||
| use: 'elm-webpack-loader' |
| @@ -125,10 +128,10 @@ if ( TARGET_ENV === 'production' ) { | |||
| }, | |||
| ]), | |||
|
|
|||
| new webpack.optimize.OccurenceOrderPlugin(), | |||
| new webpack.optimize.OccurrenceOrderPlugin(), | |||
There was a problem hiding this comment.
This is on by default and can therefore be removed
|
|
||
| // extract CSS into a separate file | ||
| new ExtractTextPlugin( 'static/css/[name]-[hash].css', { allChunks: true } ), | ||
| new ExtractTextPlugin( 'static/css/[name]-[hash].css'), |
There was a problem hiding this comment.
I'm not sure if plain filename is supported, nor why you removed allChunks: true, but according to this, the new code should be
new ExtractTextPlugin({
filename: 'static/css/[name]-[hash].css',
allChunks: true
})| { | ||
| test: /\.elm$/, | ||
| exclude: [/elm-stuff/, /node_modules/], | ||
| loader: 'elm-hot!elm-webpack?verbose=true&warn=true&debug=true' | ||
| loader: 'elm-hot-loader!elm-webpack-loader?verbose=true&warn=true&debug=true' |
There was a problem hiding this comment.
Should probably use the new "array of object"-syntax
use: [
{
loader: 'elm-hot-loader'
},
{
loader: 'elm-webpack-loader',
options: {
verbose: true,
debug: true,
warn: true,
}
}
]
No description provided.