upgrade to webpack 2 #53
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| module.exports = { | ||
| plugins: [ | ||
| require('autoprefixer')( { browsers: ['last 2 versions'] } ) | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,20 +19,20 @@ var commonConfig = { | |
|
|
||
| output: { | ||
| path: outputPath, | ||
| filename: `static/js/${outputFilename}`, | ||
| publicPath: '/' | ||
| }, | ||
|
|
||
| resolve: { | ||
| extensions: ['.js', '.elm'] | ||
| }, | ||
|
|
||
| module: { | ||
| noParse: /\.elm$/, | ||
| rules: [ | ||
| { | ||
| test: /\.(eot|ttf|woff|woff2|svg)$/, | ||
| use: 'file-loader' | ||
|
There was a problem hiding this comment. I think this should still be |
||
| } | ||
| ] | ||
| }, | ||
|
|
@@ -45,8 +45,6 @@ var commonConfig = { | |
| }) | ||
| ], | ||
|
|
||
| } | ||
|
|
||
| // additional webpack settings for local env (when invoked by 'npm start') | ||
|
|
@@ -67,15 +65,15 @@ if ( TARGET_ENV === 'development' ) { | |
| }, | ||
|
|
||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.elm$/, | ||
| exclude: [/elm-stuff/, /node_modules/], | ||
| loader: 'elm-hot-loader!elm-webpack-loader?verbose=true&warn=true&debug=true' | ||
|
There was a problem hiding this comment. Should probably use the new "array of object"-syntax use: [
{
loader: 'elm-hot-loader'
},
{
loader: 'elm-webpack-loader',
options: {
verbose: true,
debug: true,
warn: true,
}
}
] |
||
| }, | ||
| { | ||
| test: /\.(css|scss)$/, | ||
| use: [ | ||
| 'style-loader', | ||
| 'css-loader', | ||
| 'postcss-loader', | ||
|
|
@@ -97,19 +95,24 @@ if ( TARGET_ENV === 'production' ) { | |
| entry: entryPath, | ||
|
|
||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.elm$/, | ||
| exclude: [/elm-stuff/, /node_modules/], | ||
| use: 'elm-webpack-loader' | ||
|
|
||
| }, | ||
| { | ||
| test: /\.(css|scss)$/, | ||
| use: ExtractTextPlugin.extract( | ||
| { | ||
| fallback: "style-loader", | ||
| use: [ | ||
| 'css-loader', | ||
| 'postcss-loader', | ||
| 'sass-loader' | ||
| ], | ||
| allChunks: true | ||
| }) | ||
| } | ||
| ] | ||
| }, | ||
|
|
@@ -125,10 +128,10 @@ if ( TARGET_ENV === 'production' ) { | |
| }, | ||
| ]), | ||
|
|
||
| new webpack.optimize.OccurrenceOrderPlugin(), | ||
|
There was a problem hiding this comment. This is on by default and can therefore be removed |
||
|
|
||
| // extract CSS into a separate file | ||
| new ExtractTextPlugin( 'static/css/[name]-[hash].css'), | ||
|
There was a problem hiding this comment. I'm not sure if plain filename is supported, nor why you removed new ExtractTextPlugin({
filename: 'static/css/[name]-[hash].css',
allChunks: true
}) |
||
|
|
||
| // minify & mangle JS/CSS | ||
| new webpack.optimize.UglifyJsPlugin({ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of IDE and OS specific stuff in project's
.gitignorefiles. Imo this sort of things should be handled in a global.gitignoreper machine. But after all that's just personal taste, so definitely up for discussion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree :) It is better to enable global
.gitignorewith commandgit config --global core.excludesfile ~/.gitignore_global.