-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe key user journeys / workflows in vignette #89
Conversation
Merge branch 'main' into user-journeys # Conflicts: # vignettes/workflow.Rmd
Merge branch 'main' into user-journeys # Conflicts: # DESCRIPTION # vignettes/workflow.Rmd
Now ready for review. Workflow knits and makes for a reasonable use case. I'm not happy yet with the rendering of tabels in the quality control section but for a first submission it will do. I suspect you may have qualms with my use of ggrepel, but perhaps we can add that as a Suggests dependency? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FANTASTIC addition, @mdingemanse! Thank you!
I've gone through quickly and roughly (looking at the time ;)), but I hope these comments are helpful. Most of them can be disregarded; they are opinions, not facts, so don't worry too much about them. I do hope they are helpful!
In addition, and ABSOLUTELY NOT to be implemented here, but I wanted to share a tip for git-controlled markdown files that I have always appreciated: keeping the lines short (this will not affect the rendered text, as newlines in markdown are read as spaces) helps to keep track of the line-by-line changes that git monitors.
If you change a single character in an enormous line, this will read as a diff for the entire line. GitHub visualizes character-by-character differences nowadays — it didn't use to — but if you're not checking your diffs on github it can be quite annoying to have to parse a long sentence for a small change...
Again, great work! Much, much appreciated.
Co-authored-by: Barbara Vreede <[email protected]>
Co-authored-by: Barbara Vreede <[email protected]>
Co-authored-by: Barbara Vreede <[email protected]>
Dear @mdingemanse and @bvreede, I still see some conversations pending resolution. Please let me know when this is ready so I can merge and submit :) |
Now all resolved! |
A single vignette
workflow.Rmd
should have descriptions of some of the basic tasks of (1) quality control and (2) conversation visualisation that we anticipate users will want to use talkr for.