lsp-terraform: fix invalid keys

[daedric]

Hi,
I'm a doomemacs user and I got errors in the terraform client. I'm not sure when/where those changes occurred.
Let me know whether this needs rework,
Cheers,

[yyoncho]

CI does not like this change. Note that when lsp-interface member is using _ it is converted in - when destructoring.

cc @psibi

[psibi]

@daedric Can you let me know the exact error message you are seeing ? Also, I remember someone previously facing same issue which got resolved by cleaning up the old *.elc and *.eln files.

[daedric]

The error I have is:

Error running timer: (error "Eager macro-expansion failure: (error \"Unknown key: :docs-link.  Available keys: (:name :docs_link :version :source_type :dependent_modules)\")")

internal-macroexpand-for-load: Eager macro-expansion failure: (error "Unknown key: :docs-link.  Available keys: (:name :docs_link :version :source_type :dependent_modules)")

Deleting the elc and eln has not changed anything, if I don't apply my patch I get the same error (find . -type f -iname '*terraform*.el[n,c]' -delete) .

Happy to test whatever you feel might helpful :)

I could reset the whole config so that there is no chance for outdated elc/n.
It might be of interest, but I'm using Emacs 29.1.

[daedric]

it started to work again without :/
Sorry for the noise

[psibi]

@daedric No worries, thanks for the confirmation! I remember same thing happening previously to someone too: #3757

[jmcarcell]

I also get the same error when using lsp from master but not with 8.0.0

[daedric]

Actually it is strange, for me:

• if I open a Go file with master, I'll get the error every time and need the patch;
• if I open a C++ file with master, it will work and the LSP starts.

I worked it around by opening a Go file before a C++ because it makes it work. I did not have the time to investigate properly yet.

[yyoncho]

clean installation should fix the issue.

[jmcarcell]

@yyoncho it doesn't do it for me fater deleting everything lsp* in my packages folder and also the built folders. I actually have no idea because I have two computers both with the same version of emacs from Arch Linux that share a configuration and for one of them this issue happens consistently and for the other it doesn't
Edit: Doing a clean install does indeed fix the issue. I deleted every package and all the build files (I'm using straight) so that it was a complete build from scratch. Before I had tried deleting the lsp folders but it seems it wasn't enough.