chore: test diagnostic locations with a help of a mock LSP server #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4259eb7.
2 tasks
|
the |
9 tasks
|
Only today I noticed that ubuntu-latest + 27.2 was failing after a recent commit. It is fixed now |
jcs090218
approved these changes
Jul 23, 2024
|
Oops, I think I should have merged the other PR first. 🤔 Can you resolve the merge conflicts? Thanks! |
No, problem. #4503, that you merged, supersedes this one. I broke them into two steps to reduce the amount of code to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first part of #4501
The mock server simulates detecting diagnostics and the tests document the behavior of
lsp-modeupon receiving them.