chore: Add more tests for code locations in LSP features #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4259eb7.
2 tasks
|
Some tests aren't passing. 🤔 |
|
Yep, indeed. I'll look into why |
necto
force-pushed
the
az/more-tests-with-mock
branch
from
c6f29cb
to
c78329f
Compare
|
Fixed! 🎉 |
jcs090218
approved these changes
Jul 25, 2024
jcs090218
approved these changes
Jul 27, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #4502 (which is included in this branch at the moment, so it should be merged before the review of this PR), this change adds tests for additonal features that use code positions or ranges in the messages coming from LSP server:
As such, I consider it reaches the good enough coverage of the potentially affected code in the light of refactoring as outlined in #4501