Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stm32): disable transmitter during during half-duplex flush #3299

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

badrbouslikhin
Copy link
Contributor

This PR addresses an issue with half-duplex UART communication on STM32H7 (probably valid for all STM32s) where subsequent read cycles unexpectedly return both sent and received bytes, leading to potential data corruption.
The fix involves disabling the transmitter (before enabling the receiver) after transmission flush in half-duplex mode.

@badrbouslikhin badrbouslikhin changed the title fix(stm32): disable transmitter during half-duplex read fix(stm32): disable transmitter during after half-duplex flush Aug 30, 2024
@badrbouslikhin badrbouslikhin changed the title fix(stm32): disable transmitter during after half-duplex flush fix(stm32): disable transmitter during during half-duplex flush Aug 30, 2024
@badrbouslikhin
Copy link
Contributor Author

Is there any blocker to merge this PR?

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Oct 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 13, 2024
@Dirbaio Dirbaio added this pull request to the merge queue Oct 13, 2024
Merged via the queue into embassy-rs:main with commit 2f6273b Oct 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants