-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Strategies to Recommenders #146
Conversation
@AVHopp unfortunately a lot of files have changed event hough this is just a restructuring/renaming, but we need to prioritize this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main things I spotted:
- At several places, we actually need the word strategy, e.g. when speaking about the abstract concept of a strategy ("DoE strategy") instead of the actual object.
- In hypothesis related files, we also need to keep the word strategy.
- There are some places where I'd prefer some more explanation regarding the new naming. This is nothing too big, with the exception of the "strategy" user guide where we should add some note saying that the names do not match currently although the functionality remains as described.
6700e6c
to
56b6a5e
Compare
56b6a5e
to
9bd8234
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor question, other than that this is gucci now. Thanks for all of the tedious work :)
.meta
and.pure
for subpackagesMetaRecommender
from which old strategies now derive, their name has changed from<xyz>Strategy
to<xyz>MetaRecommender
Recommender
toPureRecommender
in analogy toMetaRecommender
NaiveHybridRecommender
toNaiveHybridSpaceRecommender
NOT included