Motor goes alone fixes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0607387)
When motor still rotates after cutting power and then is quickly reenergized the timer wouldn't reset. Next time that would happens, the timer could reach the threshold and trigger the error (cherry picked from commit f1690e7)
- This can happen often at 0 current. Cleaned up conditions order for readibility. I hope. (cherry picked from commit b601fe9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you suggested, the motor goes alone logic may need to be improved to fix E09.
Here are some bugfixes that may contribute to the E09 issue. (Similar in nature to what it was with 6kph throttle issue).
However, by themselves they do not fix E09, at least not entirely.
Btw, I think we should have a another (default) branch for releases and master stays for development.