Fix TCP socket send() immediately back to back after connect() #22630
+85
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
force-pushed
the
fix_tcp_socket_send_immediately_after_connect
branch
from
7f2abe4
to
3f02d35
Compare
sbc100
reviewed
Sep 26, 2024
sbc100
reviewed
Sep 26, 2024
sbc100
reviewed
Sep 26, 2024
sbc100
reviewed
Sep 26, 2024
test/test_sockets.py
Outdated
| @@ -350,6 +350,11 @@ def test_posix_proxy_sockets(self): | |||
| # Build and run the TCP echo client program with Emscripten | |||
| self.btest_exit('websocket/tcp_echo_client.c', args=['-lwebsocket', '-sPROXY_POSIX_SOCKETS', '-pthread', '-sPROXY_TO_PTHREAD']) | |||
|
|
|||
| # Test that multiple pthreads calling send() on the same socket produces correct ordering semantics. | |||
| def test_sockets_send_immediately_after_connect(self): | |||
There was a problem hiding this comment.
How about calling it test_sockets_send_while_connecting?
sbc100
approved these changes
Sep 27, 2024
… to send() back to back right after connecting, the send would fail because the socket is not yet actually connected. It is a bit hard to imagine where that behavior would be useful. So this PR changes this behavior to be identical to how connectionless UDP sockets are emulated: instead, connect() calls are always pretended to succeed (since we cannot synchronously establish if the connect would fail, so presume it'll work), and all send() calls that are issued while the socket is connecting will be queued to be sent after the socket actually connects.
juj
force-pushed
the
fix_tcp_socket_send_immediately_after_connect
branch
from
6fbbb76
to
cdd575e
Compare
emscripten-core#22662 Merge remote-tracking branch 'origin/main' into fix_tcp_socket_send_immediately_after_connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an emulated TCP socket is connect()ed and one attempts to send() back to back right after connecting, the send would fail because the socket is not yet actually connected.
It is a bit hard to imagine where such behavior would be useful.
So this PR changes this behavior to be identical to how connectionless UDP sockets are emulated: instead, connect() calls are always pretended to succeed (since we cannot synchronously establish if the connect would fail, so presume it'll work), and all send() calls that are issued while the socket is connecting will be queued to be sent after the socket actually connects.