Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TCP socket send() immediately back to back after connect() #22630

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Fix TCP socket send() immediately back to back after connect() #22630

merged 3 commits into from
Oct 2, 2024

Commits on Sep 30, 2024

  1. Previously, if an emulated TCP socket is connect()ed and one attempts… 

    … to send() back to back right after connecting, the send would fail because the socket is not yet actually connected.

It is a bit hard to imagine where that behavior would be useful.

So this PR changes this behavior to be identical to how connectionless UDP sockets are emulated: instead, connect() calls are always pretended to succeed (since we cannot synchronously establish if the connect would fail, so presume it'll work), and all send() calls that are issued while the socket is connecting will be queued to be sent after the socket actually connects.
    @juj
    juj committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c4b4a5d View commit details
    Browse the repository at this point in the history

  2. Address review.

    @juj
    juj committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cdd575e View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Fix merge conflict against code style refactor in 

    emscripten-core#22662

Merge remote-tracking branch 'origin/main' into fix_tcp_socket_send_immediately_after_connect
    @juj
    juj committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    df974e6 View commit details
    Browse the repository at this point in the history