-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[emrun] Don't listen to 0.0.0.0 by default (#22077) #22645
base: main
Are you sure you want to change the base?
Conversation
bug #22077 |
…core#22077) A developer might start emrun without thinking about the --hostname setting. So he might expose sensible data on the webserver to the LAN or to the Internet. It might even happen, that a vulnerable Emsdk version becomes publicly reachable. Instead use localhost (127.0.0.1) by default, which is usually sufficient for development.
5ef6a5a
to
7b0fec6
Compare
I normally do all my work over ssh and then point my browser at the IP of the my server.. so I guess I will always be adding |
Hmm hmm.. yeah, I can see that this can be tedious. Although emrun already has the default that it attempts to launch a browser, so you've been passing the --no_browser flag as well I presume? I find it tedious to need to write that If we defaulted to 0.0.0.0 and while doing so, print a warning that this will be accessible to all users, and then ask developers to opt to --hostname=127.0.0.1, then they would find it tedious. |
If you have any ideas for fixing the failed tests or making the discussed suggestions, feel free to amend a patch. |
Yes, I run with |
A developer might start emrun without thinking about the --hostname setting. So he might expose sensible data on the webserver to the LAN or to the Internet. It might even happen, that a vulnerable Emsdk version becomes publicly reachable.
Instead use localhost (127.0.0.1) by default, which is usually sufficient for development.