Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[emrun] Don't listen to 0.0.0.0 by default (#22077) #22645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[emrun] Don't listen to 0.0.0.0 by default (#22077) #22645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ See docs/process.md for more on how version tagging works.
- The number of arguments passed to Embind function calls is now only verified
with ASSERTIONS enabled. (#22591)
- Optional arguments can now be omitted from Embind function calls. (#22591)
- emrun now listens to localhost only by default.
Configure old behaviour by passing `--hostname 0.0.0.0` (#22077)

3.1.67 - 09/17/24
-----------------
Expand Down
6 changes: 3 additions & 3 deletions emrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@
processname_killed_atexit = ""

# Using "0.0.0.0" means "all interfaces", which should allow connecting to this
# server via LAN addresses. Using "localhost" should allow only connecting from
# local computer.
default_webserver_hostname = '0.0.0.0'
# server via LAN or public Internet addresses, which might be a security risk.
# Using "localhost" should allow only connecting from local computer.
default_webserver_hostname = 'localhost'

# If user does not specify a --port parameter, this port is used to launch the
# server.
Expand Down