Fix UTF16ToString in TEXTDECODER=2 and MAXIMUM_MEMORY>=2GB #24335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's up with Windows CI? Seems to be failing in download stage on several PRs. |
sbc100
approved these changes
May 15, 2025
Looks like infra flake with the chocolaty package manager. I think its fairly rare. About as common as npm infra flake I would say. |
RReverser
force-pushed
the
fix-utf16-textdecoder
branch
2 times, most recently
from
01cfa62 to
8a66970
Compare
sbc100
approved these changes
May 15, 2025
RReverser
force-pushed
the
fix-utf16-textdecoder
branch
from
8a66970 to
60b4ebb
Compare
|
FAIL [0.002s]: test_async_hello_v8 (test_core.instance) looks like a broken test on main branch. |
|
Yup, test_async_hello_v8 is unrelated. Sorry about that. |
RReverser
force-pushed
the
fix-utf16-textdecoder
branch
from
60b4ebb to
b7d209b
Compare
I accidentally noticed that Embind UTF-16 support was producing incorrect results with MAXIMUM_MEMORY over 2GB. Turns out, the `TextDecoder` implementation of `UTF16ToString` itself was broken in this mode due to bitwise ops, so I've added new tests and fixed this bug, slightly simplifying code in the process.
RReverser
force-pushed
the
fix-utf16-textdecoder
branch
from
b7d209b to
527651e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally noticed that Embind UTF-16 support was producing incorrect results with MAXIMUM_MEMORY over 2GB.
Turns out, the
TextDecoderimplementation ofUTF16ToStringitself was broken in this mode due to bitwise ops, so I've added new tests and fixed this bug, slightly simplifying code in the process.