Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantity unit of production run may be None. #26

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

daniel-k
Copy link
Member

We recently made quantity units of production runs optional in the upstream service, so we have to make the same change here as well.

We recently made quantity units of production runs optional in the
upstream service, so we have to make the same change here as well.
Copy link

github-actions bot commented Nov 29, 2023

Coverage results

Update on 2023-11-30 07:52:56.951145234 +0000

This is the coverage report for commit 5e163f6

Name                                                                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                                 4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/base.py                        65      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/client.py      20      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/models.py      51      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/client.py           19      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/models.py           34      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                                    13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                                  86      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py                                6      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                                   3      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                                 108      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py                              38      0   100%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                 447      0   100%

4 empty files skipped.

denizs
denizs previously approved these changes Nov 29, 2023
@daniel-k daniel-k force-pushed the fix/production-run-qty-unit-may-be-null branch from 6b4bffc to 5a3dafb Compare November 30, 2023 07:47
@daniel-k daniel-k requested a review from denizs November 30, 2023 08:04
@daniel-k daniel-k merged commit 36667fd into master Nov 30, 2023
9 checks passed
@daniel-k daniel-k deleted the fix/production-run-qty-unit-may-be-null branch November 30, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants