Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example notebook on how to use the sdk #32

Merged
merged 17 commits into from
Dec 7, 2023

Conversation

clehensen
Copy link
Contributor

Description
This PR adds a new examples/notebooks directory with a first introduction to python sdk notebook. Reviewing the notebook is a bit inconvenient, maybe we should use nbdime or a differnet tool for that. Otherwise, it's easiest to look at the notebook as a complete file in the code.

The notebook covers the basic steps from

  • installing required packages,
  • using the different methods of the SDK to query data,
  • explore and visualize data to
  • saving data in different formats

CC: @fzobel

@clehensen clehensen requested a review from denizs December 5, 2023 22:02
Copy link

github-actions bot commented Dec 5, 2023

Coverage results

Update on 2023-12-06 17:11:08.848487262 +0000

This is the coverage report for commit 1c70e40

Name                                                                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                                 4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/base.py                        65      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/client.py      20      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/models.py      51      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/client.py           19      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/models.py           34      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                                    13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                                  86      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py                                6      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                                   3      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                                 108      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py                              38      0   100%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                 447      0   100%

4 empty files skipped.

@clehensen clehensen requested a review from daniel-k December 6, 2023 08:38
Copy link
Member

@daniel-k daniel-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, I can image very well that this will help our customers to easily get started! 🎉 Most of my comments/suggestions are minor capitalization changes.

examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
examples/notebooks/introduction_enlyze_python_sdk.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@daniel-k daniel-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the notebook from somewhere in the docs, potentially also in the README. This file should be easily discoverable.

@clehensen clehensen force-pushed the examples/introduction-to-enlyze-python-sdk branch from b0c5333 to 612ce8a Compare December 6, 2023 15:45
@clehensen clehensen force-pushed the examples/introduction-to-enlyze-python-sdk branch from 0a868e5 to a824e53 Compare December 6, 2023 17:05
@clehensen clehensen force-pushed the examples/introduction-to-enlyze-python-sdk branch from a824e53 to 1c70e40 Compare December 6, 2023 17:07
@clehensen
Copy link
Contributor Author

Please mention the notebook from somewhere in the docs, potentially also in the README. This file should be easily discoverable.

I added a reference to the README, how do I add it to the docs?

@daniel-k
Copy link
Member

daniel-k commented Dec 7, 2023

how do I add it to the docs?

Please have a look at https://github.com/enlyze/enlyze-python/tree/master/docs, the docs are built and published automatically from here on every release.

I'd say we could add a new top level section Examples after Quickstart or put at the end of the Quickstart section.

@clehensen
Copy link
Contributor Author

Examples are added to the docs now: e798d3a

@daniel-k let me know what you think

Copy link
Member

@daniel-k daniel-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding references in the docs and the README. Good to go from side 🚀

@clehensen clehensen merged commit e79438d into master Dec 7, 2023
0 of 9 checks passed
@clehensen clehensen deleted the examples/introduction-to-enlyze-python-sdk branch December 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants