Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR-comment GitHub Action by using our forked version. #36

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

daniel-k
Copy link
Member

@daniel-k daniel-k commented Jan 24, 2024

I had to remove a problematic type annotation in the docstring of EnlyzeClient.get_appliances() as well, because that has led to a failure building the docs. For consistency, I've also removed a similar annotation in the same class. Both annotation are not strictly necessary, so this shouldn't be a big deal.

@daniel-k daniel-k force-pushed the update/gh-action-pr-comment branch from 88ee253 to 628857c Compare January 24, 2024 14:54
Copy link

Coverage results

This is the coverage report for commit 374f6d3

Name                                                                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                                 4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/base.py                        65      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/client.py      20      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/models.py      51      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/client.py           19      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/models.py           34      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                                    13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                                  86      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py                                6      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                                   3      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                                 108      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py                              38      0   100%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                 447      0   100%

4 empty files skipped.

@daniel-k daniel-k requested a review from denizs January 24, 2024 15:26
@daniel-k
Copy link
Member Author

For some context: CI seems to have broken by itself since the last PR some time ago. When I opened #35 I found CI failing for reasons unrelated to my actual PR. This PR here fixes all current CI issues.

@daniel-k daniel-k merged commit caa69aa into master Jan 24, 2024
9 checks passed
@daniel-k daniel-k deleted the update/gh-action-pr-comment branch January 24, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants