Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in existing tests #48

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix issues in existing tests #48

merged 2 commits into from
Oct 2, 2024

Conversation

daniel-k
Copy link
Member

@daniel-k daniel-k commented Oct 1, 2024

Some tests are flaky. This fixes an issue encountered in a recent CI build as well as a local test failure of Hypothesis.

  • Fix performance of test__get_timeseries_raises_on_mixed_response() resulting in Hypothesis health check error
  • Fix datetime strategies that can result in the same timestamp, throwing off tests that assert start != end

Copy link

github-actions bot commented Oct 1, 2024

Coverage results

This is the coverage report for commit b191ec1

Name                                                                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                                 4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/base.py                        70      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/client.py      20      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/models.py      52      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/client.py           19      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/models.py           44      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                                    13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                                 108      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py                                8      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                                   3      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/iterable_tools.py                           7      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                                 110      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/schema.py                                  26      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py                              38      0   100%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                 522      0   100%

4 empty files skipped.

@daniel-k daniel-k requested a review from denizs October 1, 2024 09:14
@daniel-k daniel-k merged commit f37ff83 into master Oct 2, 2024
9 checks passed
@daniel-k daniel-k deleted the fix/tests branch October 2, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants