Support running with no timeout, ignore/deprecate TIMEOUT task param #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running in a Tekton task it's better if Tekton handles the timeout, so that's why we want to be able to do this. I decide to skip the context.WithTimeout entirely rather than just set it to 100 years or whatever. Ref: https://issues.redhat.com/browse/EC-1030
simonbaird
force-pushed
the
support-no-timeout
branch
from
277cfc5 to
e374d06
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2229 +/- ##
==========================================
- Coverage 72.42% 72.42% -0.01%
==========================================
Files 88 88
Lines 7539 7546 +7
==========================================
+ Hits 5460 5465 +5
- Misses 2079 2081 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zregvart
approved these changes
Dec 20, 2024
cmd/root/root_cmd.go
Outdated
| var cancel context.CancelFunc | ||
| if globalTimeout > 0 { | ||
| ctx, cancel = context.WithTimeout(ctx, globalTimeout) | ||
| log.Debugf("globalTimeout is %d seconds", globalTimeout/time.Second) |
There was a problem hiding this comment.
A bit nicer way would be this:
Suggested change
| log.Debugf("globalTimeout is %d seconds", globalTimeout/time.Second) | |
| log.Debugf("globalTimeout is %s seconds", time.Duration(globalTimeout)) |
It's a little more user friendly this way.
Ignore the TIMEOUT param. Mention in the param description that it's now ignored and deprecated. Ref: https://issues.redhat.com/browse/EC-1030
simonbaird
force-pushed
the
support-no-timeout
branch
from
e374d06 to
03d8150
Compare
simonbaird
commented
Dec 20, 2024
| @@ -224,7 +226,8 @@ spec: | |||
| - "$(params.WORKERS)" | |||
| # NOTE: The syntax below is required to negate boolean parameters | |||
| - "--info=$(params.INFO)" | |||
| - "--timeout=$(params.TIMEOUT)" | |||
| # No timeout for EC, though Tekton may apply a timeout | |||
| - "--timeout=0" | |||
There was a problem hiding this comment.
This works quite badly on any version of EC that doesn't have this PR merged. It's probably fine (???), but I was considering using --timeout=100h for a while just to be extra cautious/paranoid.
There was a problem hiding this comment.
We can't release this version of the task without the new version of EC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Ref: https://issues.redhat.com/browse/EC-1030