Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratelimit: masked_remote_address action don't return descriptor_entry with statsd key words #36275

Closed

fix test

09dab76
Select commit
Loading
Failed to load commit list.
Closed

ratelimit: masked_remote_address action don't return descriptor_entry with statsd key words #36275

fix test
09dab76
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/ASAN skipped Sep 21, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36275/main@09dab76)

zirain @zirain 09dab76 #36275 merge main@4d99ab1

ratelimit: masked_remote_address action don't return descriptor_entry with statsd key words

Commit Message: For envoyproxy/gateway#4281, descriptor_entry with . make it's hard to export metric in prometheus in RateLimit server.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Environment

Request variables

Key Value
ref 64d8fd3
sha 09dab76
pr 36275
base-sha 4d99ab1
actor zirain @zirain
message ratelimit: masked_remote_address action don't return descriptor_entry with statsd key words...
started 1726934577.597789
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true