Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXF-99867: Integrate Alibaba Terraform Provider with Fabric Connection Examples #155

Merged
merged 10 commits into from
Nov 18, 2024

Conversation

d-bhola
Copy link
Collaborator

@d-bhola d-bhola commented Nov 14, 2024

No description provided.

Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good intial effort. See notes for requested changes. We need to very specific with customer facing details.

examples/port-2-alibaba2-connection/outputs.tf Outdated Show resolved Hide resolved
examples/port-2-alibaba2-connection/variables.tf Outdated Show resolved Hide resolved
examples/port-2-alibaba2-connection/main.tf Outdated Show resolved Hide resolved
examples/port-2-alibaba2-connection/main.tf Outdated Show resolved Hide resolved
examples/port-2-alibaba2-connection/README.md Outdated Show resolved Hide resolved
examples/port-2-alibaba2-connection/README.md Outdated Show resolved Hide resolved
examples/port-2-alibaba2-connection/README.md Outdated Show resolved Hide resolved
examples/port-2-alibaba2-connection/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good response to comments! Just a few final nit items then we can get this merged in.

Thank you, @d-bhola ! :)

* Manually accept the connection request in the Alibaba Portal for the created physical connection.

#### 4. Create the Virtual Border Router (VBR) Resource
* Remove the commented code to create the VBR resource.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thogarty Should I add in here that they need to do these commands after removing commented code -
terraform init
terraform plan
terraform apply

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the init and apply. They don't need to run the plan.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do terraform init for provider "alicloud"


#### 1. Create Connection from Equinix Terraform Provider

**Note:** The `connection_name` must follow either one of these patterns:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I leave this Note here or remove this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. You're bringing attention to something I didn't think had any issues.

special = false
}
```
* A unique `connection_name` is generated by appending a 12-character random string to the variable name given by the user.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't request another change for this, but the standard is not to end a bulleted item with a period. Glad that this document is consistent with it though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I wasn't sure what is the standard. I will remove this in my upcoming commit.

* Manually accept the connection request in the Alibaba Portal for the created physical connection.

#### 4. Create the Virtual Border Router (VBR) Resource
* Remove the commented code to create the VBR resource.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the init and apply. They don't need to run the plan.

@d-bhola
Copy link
Collaborator Author

d-bhola commented Nov 18, 2024

Outdated screenshot (updated one below)
image

@d-bhola
Copy link
Collaborator Author

d-bhola commented Nov 18, 2024

Finalized steps page -
image
image

Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @d-bhola ! :)

@thogarty
Copy link
Collaborator

image

The screenshots should be in the same comment, along with the context of why they are being shared.

@d-bhola d-bhola merged commit efc72cb into main Nov 18, 2024
4 checks passed
@d-bhola d-bhola deleted the CXF-99867-alibaba-example branch November 18, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants