-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXF-99867: Integrate Alibaba Terraform Provider with Fabric Connection Examples #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good intial effort. See notes for requested changes. We need to very specific with customer facing details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good response to comments! Just a few final nit items then we can get this merged in.
Thank you, @d-bhola ! :)
examples/port-2-alibaba-connection-with-alicloud-terraform-integration/main.tf
Outdated
Show resolved
Hide resolved
examples/port-2-alibaba-connection-with-alicloud-terraform-integration/README.md
Outdated
Show resolved
Hide resolved
examples/port-2-alibaba-connection-with-alicloud-terraform-integration/README.md
Outdated
Show resolved
Hide resolved
examples/port-2-alibaba-connection-with-alicloud-terraform-integration/README.md
Outdated
Show resolved
Hide resolved
examples/port-2-alibaba-connection-with-alicloud-terraform-integration/README.md
Outdated
Show resolved
Hide resolved
examples/port-2-alibaba-connection-with-alicloud-terraform-integration/variables.tf
Show resolved
Hide resolved
* Manually accept the connection request in the Alibaba Portal for the created physical connection. | ||
|
||
#### 4. Create the Virtual Border Router (VBR) Resource | ||
* Remove the commented code to create the VBR resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thogarty Should I add in here that they need to do these commands after removing commented code -
terraform init
terraform plan
terraform apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the init and apply. They don't need to run the plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to do terraform init
for provider "alicloud"
|
||
#### 1. Create Connection from Equinix Terraform Provider | ||
|
||
**Note:** The `connection_name` must follow either one of these patterns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I leave this Note here or remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. You're bringing attention to something I didn't think had any issues.
special = false | ||
} | ||
``` | ||
* A unique `connection_name` is generated by appending a 12-character random string to the variable name given by the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't request another change for this, but the standard is not to end a bulleted item with a period. Glad that this document is consistent with it though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I wasn't sure what is the standard. I will remove this in my upcoming commit.
* Manually accept the connection request in the Alibaba Portal for the created physical connection. | ||
|
||
#### 4. Create the Virtual Border Router (VBR) Resource | ||
* Remove the commented code to create the VBR resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the init and apply. They don't need to run the plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @d-bhola ! :)
No description provided.