Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXF-99867: Integrate Alibaba Terraform Provider with Fabric Connection Examples #155
CXF-99867: Integrate Alibaba Terraform Provider with Fabric Connection Examples #155
Changes from 3 commits
3793d99
1c98dc7
d1e7467
e2c6a1a
d34ba3f
d3c31aa
0b7c221
ed444b4
d31fcbc
ec5ce64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This header needs to be placed below the standard README.md content we usually have in the header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be sub bullets on the random string bullet, and the random string bullet needs to describe where the random string is coming from. You must put in the random string resource into the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace
to the provided name
withthe variable name given by the user
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't explaining exactly what will happen and is causing the user to lookup information to understand it. Tell them to:
terraform destroy
which will delete the Alibaba VBR and give an error on the Equinix Fabric Connection which matches the one you noted.