Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new GC rules for release with version #6469

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

modified for recommend

84ef097
Select commit
Loading
Failed to load commit list.
Open

feat: add new GC rules for release with version #6469

modified for recommend
84ef097
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 14, 2025 in 1s

15.13% (target 10.00%)

View this Pull Request on Codecov

15.13% (target 10.00%)

Details

Codecov Report

Attention: Patch coverage is 45.00000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (d217119) to head (84ef097).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ternal/apps/dop/dicehub/release/release.service.go 43.63% 26 Missing and 5 partials ⚠️
internal/apps/dop/dicehub/release/db/release.go 57.14% 6 Missing and 3 partials ⚠️
internal/apps/dop/dicehub/release/provider.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6469      +/-   ##
==========================================
+ Coverage   15.12%   15.13%   +0.01%     
==========================================
  Files        3675     3675              
  Lines      377005   377085      +80     
==========================================
+ Hits        57018    57072      +54     
- Misses     314540   314551      +11     
- Partials     5447     5462      +15     
Files with missing lines Coverage Δ
internal/apps/dop/dicehub/release/provider.go 11.78% <0.00%> (-0.14%) ⬇️
internal/apps/dop/dicehub/release/db/release.go 10.95% <57.14%> (+7.24%) ⬆️
...ternal/apps/dop/dicehub/release/release.service.go 5.56% <43.63%> (+2.29%) ⬆️

... and 6 files with indirect coverage changes