-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine API and type changes for flat requests in Pectra #12337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
changed the title
Engine API changes for flat requests in Pectra
Engine API and type changes for flat requests in Pectra
Oct 18, 2024
somnathb1
force-pushed
the
som/pectra4_engine_api
branch
from
October 18, 2024 21:41
bd7d191
to
4969caf
Compare
This was referenced Oct 18, 2024
This is Part 3/5 |
yperbasis
approved these changes
Oct 23, 2024
somnathb1
pushed a commit
that referenced
this pull request
Oct 23, 2024
somnathb1
pushed a commit
that referenced
this pull request
Oct 24, 2024
yperbasis
added a commit
that referenced
this pull request
Oct 25, 2024
Cherry pick #12337 into `release/2.61` Co-authored-by: Somnath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Requests
interface in favour of newFlatRequest
structRequestHash
calculation thatsha256
digests the set of flat requestsRequests
from block and body related structs and methodsFinalize
stage is now returned from there, both for execution and block-buildingRef1: ethereum/execution-apis#591
Ref2: ethereum/EIPs#8854
Ref3: ethereum/EIPs#8924
Needs interface change - erigontech/interfaces#239
(Tasks board - #12106)