Simplify EIP-6110 Deposit requests #12388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is part 4/5 in the series |
somnathb1
force-pushed
the
som/remove_deposit_req
branch
from
4262eb7
to
6fc953b
Compare
yperbasis
reviewed
Oct 23, 2024
yperbasis
approved these changes
Oct 24, 2024
yperbasis
added a commit
that referenced
this pull request
Oct 25, 2024
Cherry pick #12388 into `release/2.61` Co-authored-by: Somnath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FlatRequest instead of a different type - DepositRequest defined earlier. This allows all request to align, with the differences in Deposit Requests separated out into functions rather than receiver methods.
Tasks board: #12106