get rid of some NOLINTs

erigontech · Sep 17, 2024 · db06a0f · db06a0f
1 parent 06c6cc4
commit db06a0f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/silkworm/infra/grpc/client/dispatcher.hpp b/silkworm/infra/grpc/client/dispatcher.hpp
@@ -27,12 +27,12 @@ namespace silkworm::detail {
 
 template <typename Executor>
 struct ExecutorDispatcher {
-    Executor executor_;  // NOLINT(readability-identifier-naming)
+    Executor executor;
 
     template <typename CompletionToken, typename... Args>
     void dispatch(CompletionToken&& token, Args&&... args) {
         boost::asio::dispatch(
-            boost::asio::bind_executor(executor_,
+            boost::asio::bind_executor(executor,
                                        boost::asio::append(std::forward<CompletionToken>(token),
                                                            std::forward<Args>(args)...)));
     }

diff --git a/silkworm/infra/test_util/context_test_base.hpp b/silkworm/infra/test_util/context_test_base.hpp
@@ -50,13 +50,14 @@ class ContextTestBase {
 
     ~ContextTestBase();
 
-    // NOLINTBEGIN(readability-identifier-naming)
+    agrpc::GrpcContext& grpc_context() { return grpc_context_; }
+
+  protected:
     silkworm::test_util::SetLogVerbosityGuard log_guard_;
     rpc::ClientContext context_;
     boost::asio::io_context& io_context_;
     agrpc::GrpcContext& grpc_context_;
     std::thread context_thread_;
-    // NOLINTEND(readability-identifier-naming)
 };
 
 }  // namespace silkworm::test_util
diff --git a/silkworm/rpc/core/estimate_gas_oracle_test.cpp b/silkworm/rpc/core/estimate_gas_oracle_test.cpp
@@ -99,7 +99,7 @@ TEST_CASE("estimate gas") {
     RemoteDatabaseTest remote_db_test;
     test::BackEndMock backend;
     auto tx = std::make_unique<db::kv::grpc::client::RemoteTransaction>(*remote_db_test.stub,
-                                                                        remote_db_test.grpc_context_,
+                                                                        remote_db_test.grpc_context(),
                                                                         &remote_db_test.state_cache,
                                                                         ethdb::kv::block_provider(&backend),
                                                                         ethdb::kv::block_number_from_txn_hash_provider(&backend));