Move initialization functions into esp-hal-common package's soc module
#1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
Dec 27, 2023
bjoernQ
reviewed
Dec 27, 2023
bjoernQ
reviewed
Dec 27, 2023
|
Not sure if we should add an |
|
Oops, missed some files... 😁 |
jessebraham
force-pushed
the
feature/initialization
branch
from
9786dc6 to
0e3c658
Compare
|
I decided to handle those features properly instead of what I had hacked together before, so that was taken care of in #1059. I've rebased on |
Volkalex28
pushed a commit
to Volkalex28/esp-hal
that referenced
this pull request
Feb 6, 2024
…odule (esp-rs#1049) * Move initialization functions into `esp-hal-common` package's `soc` module * Simplify module paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creeping ever closer to making #446 a reality... 😅