Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: esp-hal-common - update embedded-hal rc #1051

Closed

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Dec 23, 2023

Must

  • needs a new version of embassy-time to be released

  • The code compiles without errors or warnings.

  • All examples work.

  • cargo fmt was run.

  • Your changes were added to the CHANGELOG.md in the proper section.

  • You updated existing examples or added examples (if applicable).

  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@elpiel elpiel force-pushed the chore/update-embedded-hal-versions branch from 48f44b2 to a4be912 Compare December 23, 2023 16:36
Signed-off-by: Lachezar Lechev <[email protected]>
@elpiel elpiel force-pushed the chore/update-embedded-hal-versions branch from a4be912 to 18c38bf Compare December 23, 2023 16:39
esp-hal-common/src/gpio.rs Outdated Show resolved Hide resolved
esp-hal-common/src/gpio.rs Outdated Show resolved Hide resolved
esp-hal-common/src/gpio.rs Outdated Show resolved Hide resolved
esp-hal-common/src/gpio.rs Outdated Show resolved Hide resolved
Signed-off-by: Lachezar Lechev <[email protected]>
@jessebraham
Copy link
Member

I've taken care of this in #1068, thanks anyway though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants