Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2 alternate functions #2512

Merged
merged 1 commit into from
Nov 12, 2024
Merged

S2 alternate functions #2512

merged 1 commit into from
Nov 12, 2024

Conversation

bugadani
Copy link
Contributor

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.

Testing

Describe how you tested your changes.

@bugadani bugadani marked this pull request as ready for review November 12, 2024 11:38
Copy link
Collaborator

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the functions look correctly mapped.

What about the CLK_OUTn functions? I'm guessing they're left out because the other chips left them out too.

@bugadani
Copy link
Contributor Author

What about the CLK_OUTn functions?

They are somewhat special, I didn't find esp-idf to support those either so I just ignored them. They seem to be for outputting I2S clocks, but the way they need to be configured isn't exactly compatible with the rest of the alternate functions.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jessebraham jessebraham added this pull request to the merge queue Nov 12, 2024
Merged via the queue into esp-rs:main with commit 5d9cc1a Nov 12, 2024
28 checks passed
@bugadani bugadani deleted the s2-af branch November 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants