-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for esp32p4 & updated to new released esp-idf v5.3 #226
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -26,13 +26,14 @@ jobs: | |||||
strategy: | ||||||
fail-fast: false | ||||||
matrix: | ||||||
target: ["esp32", "esp32c3", "esp32c2", "esp32c6", "esp32h2", "esp32s2", "esp32s3"] | ||||||
target: ["esp32", "esp32c3", "esp32c2", "esp32c6", "esp32h2", "esp32p4", "esp32s2", "esp32s3"] | ||||||
std-config: | ||||||
- std: true | ||||||
- std: false | ||||||
esp-idf: | ||||||
- version: v5.3 | ||||||
- version: v5.2 | ||||||
- version: v5.1 # only for compairson why no_std build fails on v5.2 | ||||||
# - version: v5.1 # only for compairson why no_std build fails on v5.2 | ||||||
# - version: master | ||||||
steps: | ||||||
- name: Setup | Rust (RISC-V) | ||||||
|
@@ -72,17 +73,17 @@ jobs: | |||||
- uses: actions/checkout@v4 | ||||||
with: | ||||||
path: /home/runner/work/esp-idf-template/esp-idf-template/github-esp-idf-template | ||||||
- name: Generate v5.2 | ||||||
if: matrix.esp-idf.version == 'v5.2' || matrix.esp-idf.version == 'v5.1' | ||||||
- name: Generate v5.3 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
if: matrix.esp-idf.version == 'v5.3' || (matrix.esp-idf.version == 'v5.2' && matrix.target != 'esp32p4') | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the point of this condition? Is it to avoid P4 and v5.2? We could add the esp-idf version to the target:
- device: esp32
esp-idf: v5.2
- device: esp32
esp-idf: v5.3
- device: esp32c2
esp-idf: v5.2
- device: esp32c2
esp-idf: v5.3
- device: esp32c3
esp-idf: v5.2
- device: esp32c3
esp-idf: v5.3
- device: esp32c6
esp-idf: v5.2
- device: esp32c6
esp-idf: v5.3
....
- device: esp32p4
esp-idf: v5.3 The matrix becomes significantly uglier though There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hmm that somehow would nullify the complete concept of a matrix if i cramp all into a linear list of options right? That its merely a vector. |
||||||
run: cargo generate --path /home/runner/work/esp-idf-template/esp-idf-template/github-esp-idf-template cargo --name ${{ matrix.target }}-${{ matrix.std-config.std }} --vcs none --silent -d mcu=${{ matrix.target }} -d advanced=true -d espidfver=${{ matrix.esp-idf.version }} -d std=${{ matrix.std-config.std }} -d devcontainer=false -d wokwi=false -d ci=false | ||||||
- name: Build | Fmt Check | ||||||
if: matrix.esp-idf.version == 'v5.2' && matrix.target == 'esp32c3' | ||||||
if: matrix.esp-idf.version == 'v5.3' && matrix.target == 'esp32c3' | ||||||
run: cd ${{ matrix.target }}-${{ matrix.std-config.std }}; cargo fmt -- --check | ||||||
- name: Build | Clippy | ||||||
if: matrix.esp-idf.version == 'v5.2' || matrix.esp-idf.version == 'v5.1' | ||||||
if: matrix.esp-idf.version == 'v5.3' || (matrix.esp-idf.version == 'v5.2' && matrix.target != 'esp32p4') | ||||||
run: cd ${{ matrix.target }}-${{ matrix.std-config.std }}; cargo clippy --no-deps -- -Dwarnings | ||||||
- name: Build | Compile | ||||||
if: matrix.esp-idf.version == 'v5.2' || matrix.esp-idf.version == 'v5.1' | ||||||
if: matrix.esp-idf.version == 'v5.3' || (matrix.esp-idf.version == 'v5.2' && matrix.target != 'esp32p4') | ||||||
run: cd ${{ matrix.target }}-${{ matrix.std-config.std }}; cargo build | ||||||
container-checks: | ||||||
name: "Container Check: ${{ matrix.target }}" | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this worth to keep it still? We removed the 5.1 option from the template