[release-1.3] Bump go toolchain to 1.22.6 #822
Conversation
Reference: - etcd-io/etcd#18443 Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
changed the title
Reference: - https://github.com/golangci/golangci-lint/releases/tag/v1.60.1 Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahrtr, henrybear327 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -1,8 +1,8 @@ | |||
| module go.etcd.io/bbolt | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
What is the requirement in this project to bump minimal go version to 1.22?
There was a problem hiding this comment.
Hey @crazy-max, the rationale is documented here!
There was a problem hiding this comment.
Still not sure why. It should be the minimal required version for this module: https://go.dev/ref/mod#go-mod-file-go
The go directive sets the minimum version of Go required to use this module.
There was a problem hiding this comment.
@ivanvc please correct me if I am wrong.
The main idea is the support: Each major Go release is supported until there are two newer major releases. [1]. Thus, we are bumping the minimal required version to make sure we are not on the unsupported Go release.
Reference:
[1] https://go.dev/doc/devel/release
There was a problem hiding this comment.
Hi @crazy-max, thanks for raising awareness of this. We have our Golang version usage documented in the etcd-io/etcd repository: https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md#golang-versions.
There was a problem hiding this comment.
Giving this a second thought. We may want to have a different policy for projects that are libraries like bbolt and raft. Should we consider staying on the oldest supported Go version until they drop support for it? @ahrtr WDYT?
There was a problem hiding this comment.
staying on the oldest supported Go version until they drop support for it
YES, that's the policy we have been following.
There was a problem hiding this comment.
Right, my bad. I got confused with the minors.
Reference: