Remove gsutil acl command for bucket permissions from release.sh #18250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bucket is already fully public so new releases don't need to run this command. This will prevent significant terminal spam during the release process as there are thousands of objects in the bucket. Signed-off-by: James Blair <[email protected]>
jmhbnz
changed the title
|
@jmhbnz, in preparation for the next 3.5 release, do you need help backporting this to |
|
/cherrypick release-3.5 |
|
@jmhbnz: new pull request created: #18286 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #18013 (comment) and #18013 (comment) we have verified our
etcd-development/etcdbucket in use forgcr.iois already fully public and manually verified that new objects pushed to the bucket automatically become public without needinggsutil acl ...command run.This pull request will dramatically reduce output spam from this script when publishing a release which can make it frustrating to scrollback and review output.
We should merge and backport this before
v3.5.15is released.Fixes #18013