Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Remove gsutil acl command for bucket permissions from release.sh #18286

Merged
merged 1 commit into from
Jul 6, 2024
Merged

[3.5] Remove gsutil acl command for bucket permissions from release.sh #18286

merged 1 commit into from
Jul 6, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #18250

/assign jmhbnz

@jmhbnz
Remove gsutil acl command for bucket permissions.
9aaaafe 
The bucket is already fully public so new releases don't need to run this command.

This will prevent significant terminal spam during the release process as there are thousands of objects in the bucket.

Signed-off-by: James Blair <[email protected]>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 5, 2024
Merged
@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jmhbnz
jmhbnz approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green
/ok-to-test
/lgtm

@jmhbnz
Copy link
Member

jmhbnz commented Jul 5, 2024

cc @ivanvc, @ahrtr

ivanvc
ivanvc approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green.

@jmhbnz, there's no OWNERS in the release-3.5 branch. Should we open an issue? Or should we just copy whatever is on main?

@jmhbnz
Copy link
Member

jmhbnz commented Jul 5, 2024 •
edited
Loading

@jmhbnz, there's no OWNERS in the release-3.5 branch. Should we open an issue? Or should we just copy whatever is on main?

Hmm yeah we should probably backport the migration to OWNERS. Do you agree @ahrtr and @serathius? If so we can re-open #16367 and do the backports under that umbrella.

@ahrtr
Copy link
Member

ahrtr commented Jul 5, 2024

@jmhbnz, there's no OWNERS in the release-3.5 branch. Should we open an issue? Or should we just copy whatever is on main?

Hmm yeah we should probably backport the migration to OWNERS. Do you agree @ahrtr and @serathius? If so we can re-open #16367 and do the backports under that umbrella.

Works for me. Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 472de10 into etcd-io:release-3.5 Jul 6, 2024
27 checks passed
@jmhbnz jmhbnz changed the title [release-3.5] Remove gsutil acl command for bucket permissions from release.sh [3.5] Remove gsutil acl command for bucket permissions from release.sh Jul 6, 2024
@ivanvc ivanvc mentioned this pull request Jul 15, 2024
Closed
4 tasks
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
@jmhbnz @aneesh1
Merge pull request etcd-io#18286 from k8s-infra-cherrypick-robot/cher…
97c71b8 
…ry-pick-18250-to-release-3.5

[release-3.5] Remove gsutil acl command for bucket permissions from release.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees

@jmhbnz jmhbnz

Labels
ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @jmhbnz @ahrtr @ivanvc