Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/prometheus/client_golang from 1.20.3 to 1.20.4 in /tools/mod #18631

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 23, 2024

Bumps github.com/prometheus/client_golang from 1.20.3 to 1.20.4.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.20.4

  • [BUGFIX] histograms: Fix a possible data race when appending exemplars vs metrics gather. #1623
Changelog

Sourced from github.com/prometheus/client_golang's changelog.

Unreleased

  • [BUGFIX] histograms: Fix possible data race when appending exemplars vs metrics gather. #1623
Commits
  • 05fcde9 Merge pull request #1623 from krajorama/data-race-in-histogram-write
  • 209f4c0 Add changelog
  • 1e398cc native histogram: Fix race between Write and addExemplar
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.3 to 1.20.4.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.20.3...v1.20.4)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 23, 2024
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (bd93a00) to head (f4211a1).

Current head f4211a1 differs from pull request most recent head 76e93da

Please upload reports for the commit 76e93da to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 15 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18631   +/-   ##
=======================================
  Coverage   68.75%   68.76%           
=======================================
  Files         420      420           
  Lines       35522    35522           
=======================================
+ Hits        24423    24426    +3     
+ Misses       9677     9668    -9     
- Partials     1422     1428    +6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd93a00...76e93da. Read the comment docs.

@henrybear327
Copy link
Contributor

Before

github.com/prometheus/client_golang version in all go mod files
./etcdutl/go.mod:       github.com/prometheus/client_golang v1.20.3 // indirect
./go.mod:       github.com/prometheus/client_golang v1.20.3 // indirect
./tools/mod/go.mod:     github.com/prometheus/client_golang v1.20.3 // indirect
./tests/go.mod: github.com/prometheus/client_golang v1.20.3
./server/go.mod:        github.com/prometheus/client_golang v1.20.3
./client/v3/go.mod:     github.com/prometheus/client_golang v1.20.3

@henrybear327
Copy link
Contributor

After

./etcdutl/go.mod:       github.com/prometheus/client_golang v1.20.4 // indirect
./go.mod:       github.com/prometheus/client_golang v1.20.4 // indirect
./tools/testgrid-analysis/go.mod:       github.com/prometheus/client_golang v1.20.4 // indirect
./tools/mod/go.mod:     github.com/prometheus/client_golang v1.20.4 // indirect
./etcdctl/go.mod:       github.com/prometheus/client_golang v1.20.4 // indirect
./tests/go.mod: github.com/prometheus/client_golang v1.20.4
./server/go.mod:        github.com/prometheus/client_golang v1.20.4
./client/v3/go.mod:     github.com/prometheus/client_golang v1.20.4

henrybear327 added a commit to henrybear327/etcd that referenced this pull request Sep 25, 2024
henrybear327 added a commit to henrybear327/etcd that referenced this pull request Sep 25, 2024
henrybear327 added a commit to henrybear327/etcd that referenced this pull request Sep 25, 2024
henrybear327 added a commit to henrybear327/etcd that referenced this pull request Sep 25, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 25, 2024

Looks like github.com/prometheus/client_golang is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Sep 25, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/tools/mod/github.com/prometheus/client_golang-1.20.4 branch September 25, 2024 23:36
a-nych pushed a commit to a-nych/etcd that referenced this pull request Oct 16, 2024
a-nych pushed a commit to a-nych/etcd that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tooling dependencies Pull requests that update a dependency file go Pull requests that update Go code needs-ok-to-test size/XS
Development

Successfully merging this pull request may close these issues.

3 participants