-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: address revive unexported-return issues #18645
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 28 files with indirect coverage changes @@ Coverage Diff @@
## main #18645 +/- ##
==========================================
- Coverage 68.78% 68.77% -0.02%
==========================================
Files 420 420
Lines 35539 35539
==========================================
- Hits 24446 24442 -4
- Misses 9665 9668 +3
- Partials 1428 1429 +1 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ivanvc
3e5173b
to
7d322df
Compare
/retest |
Signed-off-by: Ivan Valdes <[email protected]>
7d322df
to
3654d03
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the first pull request aiming to enable the
unexported-return
revive lint rule from golangci-lint.The aim is to ensure that the structs returned from exported functions are exported, too.
In this pull request, the following structs are now exported:
etcdserverpb.TxnRequestStringer
, previouslytxnRequestStringer
, as it is returned by the exported functionNewLoggableTxnRequest()
.etcdserverpb.LoggablePutRequest
, previouslyloggablePutRequest
, as it is returned by the exported functionNewLoggablePutRequest()
.Part of #18370.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.