Consume CommunicatorPipelineSharedWrapper in transform_mpi
#1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run not yet tested...let's see what happens |
msimberg
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Thank you @albestro for spotting this!
We might, separately, want to check if this actually improves performance at all, but I don't think that needs to block merging this. We'll probably also find out next time we do benchmarks.
Co-authored-by: Mikael Simberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
CommunicatorPipelineExclusiveWrapperis the only object that gets consumed just after an MPI operation is posted.This should happen also for
CommunicatorPipelineSharedWrapperfor the same exact reason.transform_mpiand polling support #1125 and adapt documentation accordingly