Isthmus: withdrawals root in block header #383
+83
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
protolambda
changed the title
vdamle
changed the title
vdamle
force-pushed
the
l2-withdrawals-root
branch
from
8d2f6ac
to
823e2d9
Compare
|
Rebased changes in this branch with latest changes in |
This was referenced Nov 1, 2024
vdamle
force-pushed
the
l2-withdrawals-root
branch
from
823e2d9
to
91c2f21
Compare
vdamle
force-pushed
the
l2-withdrawals-root
branch
from
91c2f21
to
de78b7b
Compare
…thdrawals storage root
vdamle
force-pushed
the
l2-withdrawals-root
branch
from
de78b7b
to
8ff4f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
L2 withdrawals storage root is retrieve from the state upon block-sealing, and then inserted into the header as withdrawals-root.
The L1 withdrawals-root is computed as an MPT hash of withdrawals operations. The OP-Stack uses contract-storage instead. In some places this means we have to verify the block-body withdrawals-list is empty, while the header is set to the storage root.
Tests
Work in progress.
Additional context
This PR is used as feature-branch. Changes will not be merged into
optimismuntil the withdrawals changes (specs, op-geth, op-node, and ideally other implementations) are complete for Holocene upgrade.Metadata
Part of ethereum-optimism/optimism#12044